| Summary: | dev-python/urlgrabber-3.9.1 fails with TypeError: can't multiply sequence by non-int of type 'float' | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Tuukka Mäkinen <tukem+bugs.gentoo.org> |
| Component: | [OLD] Development | Assignee: | Python Gentoo Team <python> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | andreis.vinogradovs, djc |
| Priority: | High | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 302614, 309805 | ||
Google search on the error message reveals that Debian has a patch that fixes also this issue. I didn't go through their patch carefully enough to understand what else it does. http://patch-tracker.debian.org/package/urlgrabber/3.9.1-4 The important part for this case is in grabber_fix.diff @@ -1532,11 +1589,14 @@ def _over_max_size(self, cur, max_size=None): if not max_size: - max_size = self.size - if self.opts.size: # if we set an opts size use that, no matter what - max_size = self.opts.size + if not self.opts.size: + max_size = self.size + else: + max_size = self.opts.size + if not max_size: return False # if we have None for all of the Max then this is dumb - if cur > max_size + max_size*.10: + + if cur > int(float(max_size) * 1.10): I am also having this problem and can confirm that the Debian patch works for me. Confirm this bug Please test this patch: http://yum.baseurl.org/gitweb?p=urlgrabber.git;a=commitdiff_plain;h=89cc380a2a251a1d2d8b91cf6df170fa546597aa (In reply to comment #4) > Please test this patch: > http://yum.baseurl.org/gitweb?p=urlgrabber.git;a=commitdiff_plain;h=89cc380a2a251a1d2d8b91cf6df170fa546597aa I managed to construct suitable patch from this and debian's one. If no complains, i commit it in half an our. Fixed in tree now *urlgrabber-3.9.1-r1 (06 Apr 2011) 06 Apr 2011; Maxim (maksbotan) <kolmax94@gmail.com> +urlgrabber-3.9.1-r1.ebuild, +files/urlgrabber-3.9.1.patch: Revision bump, imported upstream patch. Fixes bug #346753 |
While testing mic (meego-image-creator) that I'd just made an ebuild for I got an error from urlgrabber: * About to connect() to download.meego.com port 80 (#0) * Trying 140.211.166.231... 2010-11-25 13:02:02,939 max_size = 34065 max_size = 34065 Traceback (most recent call last): File "/usr/lib/python2.6/site-packages/urlgrabber/grabber.py", line 1522, in _progress_update if self._over_max_size(cur=self._amount_read-self._reget_length): File "/usr/lib/python2.6/site-packages/urlgrabber/grabber.py", line 1541, in _over_max_size if cur > max_size + max_size*.10: TypeError: can't multiply sequence by non-int of type 'float'