| Summary: | preliminary gtranscode ebuild | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Graeme Humphries <unit3> |
| Component: | Current packages | Assignee: | Gentoo Media-video project <media-video> |
| Status: | RESOLVED FIXED | ||
| Severity: | enhancement | CC: | kzimmerm, moixa |
| Priority: | High | Keywords: | EBUILD |
| Version: | 1.4 | ||
| Hardware: | All | ||
| OS: | All | ||
| URL: | http://www.fuzzymonkey.org/newfuzzy/software/gtranscode/ | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
gtranscode 0.3 ebuild
New gtranscode ebuild gtranscode-0.3.ebuild.diff |
||
|
Description
Graeme Humphries
2003-11-28 18:26:57 UTC
Created attachment 21437 [details]
gtranscode 0.3 ebuild
oh yeah, here it is. :)
Please look at the other ebuilds already in the portage tree and make yours look more like the rest. A reading of http://dev.gentoo.org/~liquidx/ebuildmistakes.html would probably be a good starting point as well. Thanks. Funny, I looked at liquidx's page, and I can't see any of the problems he brings up in my ebuild. Would you care to comment exactly what you're concerned about, since I just used the skeleton ebuild? If that base ebuild is not properly structured, than perhaps a better base ebuild should be put into portage. [quote] # NOTE: The comments in this file are for instruction and documentation. # They're not meant to appear with your final, production ebuild. Please # remember to remove them before submitting or committing your ebuild. [/quote] Apart from that the ebuild seems fine. You could use doexe in scr_install(), though... Cheers, Marc. Ahhh, right, stripping the comments out. I never do that for my own ebuild, though, because the comments remind me about what I'm supposed to be doing. ;) However, the doexec suggestion is a good idea, I just forgot about it since I threw together the ebuild in about 5 minutes. It's not like it was a particularly complicated program to compile or install. ;) Comment on attachment 21437 [details]
gtranscode 0.3 ebuild
please submit a reviewed ebuild
Created attachment 22862 [details]
New gtranscode ebuild
Just stumbled over this bug.
Attached the comment-stripped, doexe - version of the ebuild.
Cheers,
Tobias
Created attachment 44058 [details]
gtranscode-0.3.ebuild.diff
There where dependecies missing and unused USE flages declared. Should be fixed
now.
kai
Is in the tree now. kai |
