Bug 345985

Summary:	x11-themes/fvwm-crystal: fvwm-crystal.generate-menu initialized badly
Product:	Gentoo Linux	Reporter:	jan vereecke <vereecke.jan>
Component:	Current packages	Assignee:	No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it <maintainer-needed>
Status:	RESOLVED FIXED
Severity:	minor
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	generate-menu-Makefile.patch Introduce DESTDIR into the Makefile diff for fvwm-crystal-3.0.6-r2-ebuild Fix both this issue and bug 332117

Description jan vereecke 2010-11-18 15:20:41 UTC

fvwm-crystal.generate-menu

Reproducible: Always

Steps to Reproduce:
1. Install fvwm-crystal
2. from console run fvwm-crystal.generate-menu as root
3. observe that the tool tries to generate a menu from/to entries in /var/tmp/portage that don't exist anymore
Actual Results:  
You are running generate-fvwm-crystal-menu as user root.
FVWM-Crystal menu entries will be installed in
/var/tmp/portage/x11-themes/fvwm-crystal-3.0.6-r1/image/usr/share/fvwm-crystal/fvwm/Applications and the icons in /var/tmp/portage/x11-themes/fvwm-crystal-3.0.6-r1/image/usr/share/fvwm-crystal/fvwm/icons/Default
The program will search for existing menu entries in /var/tmp/portage/x11-themes/fvwm-crystal-3.0.6-r1/image/usr/share/fvwm-crystal/fvwm/Applications and for existing
 icons in /var/tmp/portage/x11-themes/fvwm-crystal-3.0.6-r1/image/usr/share/fvwm-crystal/fvwm/icons/Default


Expected Results:  
once installed, the tool should try to use /usr/share/fvwm-crystal/fvwm/ as a base directory for input/output



In the script, just before the ebuild install step, the following variables should be written:
FC_MENUBASEROOT=/usr/share/fvwm-crystal/fvwm/Applications
FC_ICONBASEROOT=/usr/share/fvwm-crystal/fvwm/icons/Default

Now, this has to be done manually after each fvwm installation

Comment 1 No Name 2010-11-30 23:12:57 UTC

I also have this seen and have also changed it like the reporter and now all works fine!

Please change it per default so nobody need testing to become the conclusion which is so simple...

thanks.

Comment 2 David Abbott (RETIRED) gentoo-dev

2010-12-01 02:24:58 UTC

Created attachment 256009 [details, diff]
generate-menu-Makefile.patch

Comment 3 Dominique Michel 2011-02-20 12:45:25 UTC

Created attachment 263155 [details, diff]
Introduce DESTDIR into the Makefile

I come to another fix for this issue, it is to introduce DESTDIR into the Makefile.
The patch is between 3.0.6 and the svn repository.

Comment 4 Dominique Michel 2011-02-20 12:50:51 UTC

Created attachment 263157 [details, diff]
diff for fvwm-crystal-3.0.6-r2-ebuild

This diff is intended to generate a new ebuild for use with the Makefile patch

Comment 5 Dominique Michel 2011-02-20 12:59:03 UTC

Created attachment 263159 [details, diff]
Fix both this issue and bug 332117

Comment 6 Samuli Suominen (RETIRED) gentoo-dev

2012-01-23 17:39:25 UTC

+*fvwm-crystal-3.0.6-r2 (23 Jan 2012)
+
+  23 Jan 2012; Samuli Suominen <ssuominen@gentoo.org>
+  +fvwm-crystal-3.0.6-r2.ebuild, +files/fvwm-crystal-build.patch:
+  Fix bad initialization of generate-menu wrt #345985. Use "emake install" with
+  DESTDIR instead of "einstall".