| Summary: | sys-devel/flex autotools sanitisation for cross-compile | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Diego Elio Pettenò (RETIRED) <flameeyes> |
| Component: | New packages | Assignee: | Gentoo's Team for Core System packages <base-system> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | High | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
new ebuild
Autotools patch Comparison patch for the ebuild |
||
|
Description
Diego Elio Pettenò (RETIRED)
2010-11-16 18:24:43 UTC
Created attachment 254525 [details]
new ebuild
Created attachment 254527 [details, diff]
Autotools patch
Created attachment 254529 [details, diff]
Comparison patch for the ebuild
you probably want ${DEB_DIFF:+...}
i guess the isatty patch is also part of the Debian patchset ?
i'd prefer the epatch be kept as sep invocations as it's easier to add trailing comments that way
since you've updated the EAPI, might as well drop the die from econf
otherwise, this looks fine to me
Debian has a different solution for the isatty() prototype, they simply include unistd.h as long as _Win32 is not defined. I tested with doxygen (that was listed in the patch description) and it builds fine. ACK for the multiple-epatch; I went this way to avoid a [[ -n ]] but I guess it looks clumsier this way than the other way. In tree. |