Summary: | eselect news module: Sort news items by their (reverse?) date | ||
---|---|---|---|
Product: | Gentoo Hosted Projects | Reporter: | Sergey S. Starikoff <Ikonta> |
Component: | eselect | Assignee: | Gentoo eselect Team <eselect> |
Status: | RESOLVED FIXED | ||
Severity: | enhancement | Keywords: | InVCS |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | x86 | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
patch for news.eselect
patch for news.eselect |
Description
Sergey S. Starikoff
2010-11-08 09:27:05 UTC
Looks like an option like --sort=date could be useful here. A patch would be most welcome. ;-) Created attachment 253929 [details, diff]
patch for news.eselect
That was easier than I thought. Can you try attached patch please?
It's being sorted by date now, but in forward order. Why do you think that reverse order would be better?
Created attachment 253955 [details, diff]
patch for news.eselect
Updated patch, use sort(1) for better efficiency.
(In reply to comment #2) > That was easier than I thought. Can you try attached patch please? Excuse me, currently I can't check the patch. I'll do it as soon, as it will be possible. > It's being sorted by date now, but in forward order. Why do you think that > reverse order would be better? > When I wrote it, I thought first of all about usability: In this case the last news item could be received by the same command: $ eselect news read 1 Independently on number of news items stored and time. In SVN: <http://sources.gentoo.org/cgi-bin/viewvc.cgi/eselect?view=revision&revision=780> (In reply to comment #4) > > It's being sorted by date now, but in forward order. Why do you think that > > reverse order would be better? > > When I wrote it, I thought first of all about usability: > In this case the last news item could be received by the same command: > $ eselect news read 1 > Independently on number of news items stored and time. I'm well aware of the fact that some newsreaders sort messages in reverse order, while others use forward order. This is mainly a matter of personal taste. I prefer the forward ordering: If the user specifies ascending numbers for the "read" action (e.g. "eselect news read 1 2 3") he will then get the messages in the sequence in which they were posted. Best would be to make it configurable, but we don't have a config file for eselect yet. Fixed in eselect-1.2.12. Thank you for bringing this up. |