Summary: | media-libs/libquicktime: compilation fails with x11-libs/gtk+-2.22 | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Lars Wendler (Polynomial-C) (RETIRED) <polynomial-c> |
Component: | [OLD] Library | Assignee: | Gentoo Media-video project <media-video> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | canarauc, kiorky, tetromino |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 339223 | ||
Attachments: |
build.log
libquicktime-1.1.5-gtk+-2.22.patch EBUILD |
Description
Lars Wendler (Polynomial-C) (RETIRED)
2010-10-30 20:05:12 UTC
Created attachment 252615 [details]
build.log
Created attachment 252743 [details, diff]
libquicktime-1.1.5-gtk+-2.22.patch
Patch to allow libquicktime-1.1.5 to build with gtk+-2.22
It replaces calls to GTK_WIDGET_SET_FLAGS(foo, GTK_CAN_DEFAULT) with gtk_widget_set_can_default(foo, TRUE).
Compatibility notes: the gtk_widget_set_can_default() function first appeared in gtk+-2.18. Since the oldest version of gtk2 in portage is 2.18.7, we do not need any gtk+ version-dependent ifdefs. Upstream might want them though, depending on whether they want to support obsolete gtk+ versions.
It should be enough to remove -DGTK_DISABLE_DEPRECATED from the build system. The GTK+ patch should go upstream developers meanwhile. Created attachment 254287 [details]
EBUILD
I confirm both problem and patch resolution. You can also find an ebuild including this patch on my overlay and in attchement. (hg clone http://hg.cryptelium.net/hg/system/gentoo/overlay/ or play with layman and the layman.xml in my overlay) please send the patch upstream + 14 Nov 2010; Samuli Suominen <ssuominen@gentoo.org> + libquicktime-1.1.5.ebuild: + Remove -DGTK_DISABLE_DEPRECATED from build flags wrt #343419 by Lars + Wendler. |