Bug 342763 – www-plugins/lightspark-0.4.4.3 sound support improvement

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Michael Weber (RETIRED) 2010-10-26 13:26:39 UTC]

Hi,

I just stumbled over this by accident, and had trouble to enable sound.
The CMakefile.txt describes none, alsa, pulse and openal sound output.
Alsa is broken, due to missing dir backends/interfaces/audio/alsa.
Pulseaudio compiles (not tested).
Openal is broke 8-(

My suggested improvement is the handling of the use-flag enabled audio plugins __and__ a warning if there's no-one enabled.

[Comment 1 Michael Weber (RETIRED) 2010-10-26 14:01:13 UTC]

--- lightspark-0.4.4.3.ebuild   2010-10-18 18:20:16.000000000 +0200
+++ lightspark-0.4.4.3-r1.ebuild        2010-10-26 15:00:16.817761272 +0200
@@ -12,7 +12,7 @@
 LICENSE="LGPL-3"
 SLOT="0"
 KEYWORDS="~amd64 ~x86"
-IUSE="nsplugin pulseaudio"
+IUSE="nsplugin openal pulseaudio"
 
 RDEPEND="dev-cpp/libxmlpp:2.6
        dev-libs/libpcre[cxx]
@@ -48,13 +48,26 @@
        "${FILESDIR}"/${PN}-0.4.4.3-cmakelists.patch
 )
 
-src_configure() {
-       local audiobackends
-       use pulseaudio && audiobackends=pulse
+pkg_setup() {
+       my_audiobackend=""
+
+       # alsa is in the CMakefile.txt but broken dur to missing backends/interfaces/audio/alsa
+       #use alsa && my_audiobackend="${my_audiobackend} alsa"
+
+       use openal && my_audiobackend="${my_audiobackend} openal"
+       use pulseaudio && my_audiobackend="${my_audiobackend} pulse"
+
+       if [ -z ${my_audiobackend} ] ; then
+               elog "No audio backend enabled. You will hear no sound"
+               my_audiobackend="none"
+       fi
+}
+
 
+src_configure() {
        local mycmakeargs=(
                $(cmake-utils_use nsplugin COMPILE_PLUGIN)
-               -DAUDIO_BACKEND="${audiobackends}"
+               -DAUDIO_BACKEND="${my_audiobackend}"
                -DPLUGIN_DIRECTORY=/usr/$(get_libdir)/${PN}/plugins
        )

[Comment 2 Chí-Thanh Christopher Nguyễn 2010-10-26 14:41:48 UTC]

The audio plugins are still very unfinished. Probably not before 0.5 release it makes sense to invest work in that.

[Comment 3 Chí-Thanh Christopher Nguyễn 2011-07-27 15:37:06 UTC]

Fixed in CVS.