Summary: | xcb-proto-1.6 requires a negative value fix | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Account removed <96bd763529be62c7350d43e8ae67f9623c998ddc> |
Component: | New packages | Assignee: | Gentoo X packagers <x11> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | dottedmag, realnc |
Priority: | High | Keywords: | InVCS |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | 344887 | ||
Bug Blocks: | 344827 | ||
Attachments: |
x11-apps/xwininfo/xwininfo-1.1.0-r2.ebuild
xwininfo/files/1.1.0-fix-negative.patch x11-proto/xcb-proto/xcb-proto-1.6-r1.ebuild xcb-proto/files/1.6-fix-negative.patch |
Description
Account removed
2010-10-21 11:06:08 UTC
Created attachment 251433 [details]
x11-apps/xwininfo/xwininfo-1.1.0-r2.ebuild
updated ebuild using the patch
Created attachment 251435 [details, diff]
xwininfo/files/1.1.0-fix-negative.patch
jcristau's patch to fix the bug
Note it's not a fix, it's a workaround. Proper fix would be to change types in xcb-proto. Proper fix: http://cgit.freedesktop.org/xcb/proto/commit/?id=661fe8dd7727c27467e61a0d20dc91557ce3747f thank you for the quick fix! it doesn't seem to work though for me. I rebuilt xcb-proto-1.6 with your patch and afterwards rebuilt xwininfo without the workaround patch. the value is still positive - Absolute upper-left X: 64247 in the test case. is there anything else I should rebuild? All libxcb* libraries, they are generated from xcb-proto. And then xwininfo again. wow you're damn fast! :) I rebuilt libxcb, xcb-util and unpatched =xwininfo-1.1.0-r1 from portage and it works! thank you very much! :) Created attachment 251465 [details]
x11-proto/xcb-proto/xcb-proto-1.6-r1.ebuild
updated xcb-proto ebuild using proper patch
Created attachment 251467 [details, diff]
xcb-proto/files/1.6-fix-negative.patch
the proper patch
Guys, this bug causes double virtual screen size for me from time to time. The attached fix in this bug fixes this problem. It needs to go in sooner than later I think This is fixed in xwininfo-1.1.1, xwininfo-1.1.0 is not even in portage anymore. although xwininfo is fixed, the actual bug is in xcb-proto (see #3 + #4). Added into main tree. Thanks for report and sorry for delay. Affected packages should probably be revbumped. The proto does nothing on its own, so people will not get the fix until they rebuild manually. |