Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 341171

Summary: media-video/mplayer: strange video_cards_mda check in the ebuilds
Product: Gentoo Linux Reporter: Faustus <orlovm>
Component: New packagesAssignee: Gentoo Media-video project <media-video>
Status: RESOLVED FIXED    
Severity: trivial    
Priority: High    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---

Description Faustus 2010-10-15 21:32:10 UTC
Perhaps I am misunderstanding something, but shouldn't:

    if ! use kernel_linux && ! use video_cards_mga; then
         myconf+=" --disable-mga --disable-xmga"
    fi

actually be:

    if ! use kernel_linux || ! use video_cards_mga; then
    ...

Otherwise it doesn't make sense (no way to disable mga via USE flags).
Comment 1 Tomáš Chvátal (RETIRED) gentoo-dev 2010-11-01 13:27:36 UTC
Fixed in live version. Thanks for spotting.
Comment 2 Alexis Ballier gentoo-dev 2011-12-15 14:56:34 UTC
(In reply to comment #1)
> Fixed in live version. Thanks for spotting.

closing then