Bug 341087

Summary:	sys-auth/pam_smb does not respect LDFLAGS
Product:	Gentoo Linux	Reporter:	Diego Elio Pettenò (RETIRED) <flameeyes>
Component:	Current packages	Assignee:	Gentoo's SAMBA Team <samba>
Status:	RESOLVED FIXED
Severity:	QA	CC:	esigra, mmk, sam
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	331933
Attachments:	Build log pam_smb-2.0.0_rc6-r2.ebuild pam_smb-makefile.patch pam_smb-makefile.patch

Description Diego Elio Pettenò (RETIRED) gentoo-dev

2010-10-15 06:16:21 UTC

See attached build log.

(Please do not complain about the need for looking at the build log until you can provide an easy way to open bugs with the correct data picked out of a tinderbox log. Thanks.)

Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev

2010-10-15 06:16:32 UTC

Created attachment 250655 [details]
Build log

Comment 2 Michael Mair-Keimberger (mm1ke) 2013-03-06 21:55:56 UTC

Hi, i've tried to fix the LDFLAGS issue. Below is my updated ebuild + patch. Please have a look at it:
* fixed LDFLAGS 
* fixed calling gcc/ar directly
* updated ebuild to eapi 5
* added ~amd64 since it compiles fine under amd64

Comment 3 Michael Mair-Keimberger (mm1ke) 2013-03-06 21:56:40 UTC

Created attachment 341164 [details]
pam_smb-2.0.0_rc6-r2.ebuild

updated ebuild

Comment 4 Michael Mair-Keimberger (mm1ke) 2013-03-06 21:57:03 UTC

Created attachment 341166 [details]
pam_smb-makefile.patch

patch for makefile

Comment 5 Michael Mair-Keimberger (mm1ke) 2013-03-07 17:10:15 UTC

Created attachment 341244 [details]
pam_smb-makefile.patch

I saw that gcc was still once called directly so i had another look at the makefile. Now nothing should be called directly anymore. Please have a look at the patch.

Comment 6 Larry the Git Cow gentoo-dev

2021-06-30 18:40:43 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f25ce46fc84583b528b110b606f4643f0a2c5266

commit f25ce46fc84583b528b110b606f4643f0a2c5266
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2021-06-30 18:38:29 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2021-06-30 18:38:29 +0000

    sys-auth/pam_smb: add missing libcrypt dependency, fix *FLAGS
    
    * Fix missing libcrypt dependency
    * Respect *FLAGS
    * Respect CC, AR
    
    Closes: https://bugs.gentoo.org/341087
    Closes: https://bugs.gentoo.org/725736
    Closes: https://bugs.gentoo.org/728146
    Signed-off-by: Sam James <sam@gentoo.org>

 sys-auth/pam_smb/files/10-pam_smb-bash-3.1.patch   |   5 +-
 .../files/add-various-missing-includes.patch       |  68 +++++++++++
 sys-auth/pam_smb/files/respect-FLAGS-CC-AR.patch   | 132 +++++++++++++++++++++
 ...0_rc6-r2.ebuild => pam_smb-2.0.0_rc6-r3.ebuild} |  27 ++---
 4 files changed, 214 insertions(+), 18 deletions(-)