Bug 340935

Summary:	Portage "compresses" .keep* files
Product:	Portage Development	Reporter:	Ulrich Müller <ulm>
Component:	Core - Ebuild Support	Assignee:	Portage team <dev-portage>
Status:	RESOLVED FIXED
Severity:	minor	Keywords:	InVCS
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	335925
Attachments:	proposed patch

Description Ulrich Müller gentoo-dev

2010-10-14 07:26:16 UTC

Not a big problem, but these files (e.g. generated by the keepdir command) are empty before. After compression they will have finite size and occupy one block.

Two possible solutions:
- don't compress empty .keep* files
- or, more general, don't compress any empty files

I can prepare a patch if you want. (It's a one-liner in ecompress ...)

Comment 1 Zac Medico gentoo-dev

2010-10-14 07:40:36 UTC

(In reply to comment #0)
> - or, more general, don't compress any empty files

I like this option the best.

Comment 2 Ulrich Müller gentoo-dev

2010-10-14 07:51:22 UTC

Created attachment 250531 [details, diff]
proposed patch

Comment 3 Zac Medico gentoo-dev

2010-10-14 07:52:59 UTC

That looks perfect.

Comment 4 Zac Medico gentoo-dev

2010-10-14 08:20:15 UTC

It's in git now:

http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=6d7f1ad1a4e514ee1a49228f17d3f1615712eb2b

Comment 5 Zac Medico gentoo-dev

2010-10-16 03:38:03 UTC

This is fixed in 2.1.9.19 and 2.2_rc97.