| Summary: | dev-java/java-config-2.1.11: VersionManager.package_parser parses atoms incorrectly | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Martin von Gagern <Martin.vGagern> |
| Component: | [OLD] Java | Assignee: | Java team <java> |
| Status: | CONFIRMED --- | ||
| Severity: | normal | CC: | cyprien |
| Priority: | High | Keywords: | Inclusion |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://overlays.gentoo.org/proj/java/changeset/7929 | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
Proposed quick fix
Improved fix |
||
|
Description
Martin von Gagern
2010-10-10 10:43:13 UTC
Created attachment 250099 [details, diff]
Proposed quick fix
This is a quick fix for the issue. Nevertheless I suggest someone get together with the portage development team or EAPI group and figure out a reliable regexp to match Gentoo package atoms. Despite my expectations I couldn't find such a regexp in the portage source code, at least not as easily as I had hoped.
Created attachment 250115 [details, diff] Improved fix I meant PMS, not EAPI, in comment #1. For details about the PMS document I reference below, see http://www.gentoo.org/proj/en/qa/pms.xml The regexp in the attached patch should resemble the PMS 3 specification more closely. It does, however, reject packages with a name ending in a hyphen, and doesn't model the relation between operators and the presence or absence of version numbers. Adding that would make the regexp even larger. In the long run, it might be a good idea to stop silently ignoring any part of the atoms string we cannot parse. Instead it might be better to split atoms and ensure we parse each of them completely, issuing a warning if we fail for any of them. Parsing atoms completely would allow regexps to enable backtracking, which would allow us to accept hyphens at the end of a package name. Currently, allowing a hyphen at the end of the package name will greedily consume the version delimiter, ending the match at the first digit of the version number. The regexp for package names resulted from the following interpretation based on section 3.1.2 (Package Names) of PMS 3: * >= 2 characters, not ending in a digit (here's the ending hyphen) [A-Za-z0-9+_][A-Za-z0-9+_\-]*[A-Za-z+_\-] * >= 3 characters, ending in a digit [A-Za-z0-9+_][A-Za-z0-9+_\-]*[A-Za-z+_][0-9]+ * == 1 character [A-Za-z0-9+_] * == 2 characters, ending in a digit [A-Za-z0-9+_][0-9] Ping? This has been almost a year! I saw something similar when trying to port an ebuild using java-pkg-opt-2.eclass to Prefix. Not sure where the root cause is. |