Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 339007

Summary: x11-drivers/xf86-input-synaptics: I ported the clickpad patch to xf86-input-synaptics-1.3.0
Product: Gentoo Linux Reporter: Yu Yuwei <acevery>
Component: New packagesAssignee: Gentoo X packagers <x11>
Status: CONFIRMED ---    
Severity: enhancement CC: chainsaw, eva, gartim, info, joeri, mgierok, tristan
Priority: High    
Version: unspecified   
Hardware: All   
OS: Linux   
URL: http://forums.gentoo.org/viewtopic-t-833298-start-0-postdays-0-postorder-asc-highlight-.html
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: the patch on xf86-input-synaptics-1.3.0
the ebuild apply the patch
xf86-input-synaptics-clickpat-1.4.0.patch

Description Yu Yuwei 2010-09-28 09:27:55 UTC
After I found the Clickpad patch from https://patchwork.kernel.org/patch/93837/ ,

I ported it to xf86-input-synaptics-1.3.0, and it make synaptics support left, middle, and right button click from clickpad on HP ProBook 4321s.

Wish this patch can go to the portage and help others.
Comment 1 Yu Yuwei 2010-09-28 09:29:18 UTC
Created attachment 248888 [details, diff]
the patch on xf86-input-synaptics-1.3.0
Comment 2 Yu Yuwei 2010-09-28 09:29:44 UTC
Created attachment 248890 [details]
the ebuild apply the patch
Comment 3 Joeri Capens 2011-01-07 15:52:58 UTC
This makes the right and middle button work again on my HP Mini 210, thanks!

I'm only getting a "command not found" warning:

>>> Preparing source in /var/tmp/portage/x11-drivers/xf86-input-synaptics-1.3.0/work/xf86-input-synaptics-1.3.0 ...
/var/tmp/portage/x11-drivers/xf86-input-synaptics-1.3.0/temp/environment: line 4201: x-modular_src_prepare: command not found
 * Applying xf86-input-synaptics-1.3.0-clickpad.patch ...                                                             [ ok ]
>>> Source prepared.


Is this a new command for a newer (unstable) Portage? Here's my emerge --info:

# emerge --info
Portage 2.1.9.25 (default/linux/amd64/10.0/desktop/gnome, gcc-4.4.4, glibc-2.11.2-r3, 2.6.37 x86_64)
=================================================================
System uname: Linux-2.6.37-x86_64-Intel-R-_Atom-TM-_CPU_N450_@_1.66GHz-with-gentoo-2.0.1
Timestamp of tree: Thu, 06 Jan 2011 18:15:01 +0000
distcc 3.1 x86_64-pc-linux-gnu [disabled]
app-shells/bash:     4.1_p7
dev-java/java-config: 2.1.11-r1
dev-lang/python:     2.6.6-r1, 3.1.2-r4
dev-util/cmake:      2.8.1-r2
sys-apps/baselayout: 2.0.1-r1
sys-apps/openrc:     0.6.5
sys-apps/sandbox:    2.4
sys-devel/autoconf:  2.13, 2.65-r1
sys-devel/automake:  1.8.5-r4, 1.9.6-r3, 1.10.3, 1.11.1
sys-devel/binutils:  2.20.1-r1
sys-devel/gcc:       4.4.4-r2
sys-devel/gcc-config: 1.4.1
sys-devel/libtool:   2.2.10
sys-devel/make:      3.81-r2
virtual/os-headers:  2.6.30-r1 (sys-kernel/linux-headers)
ACCEPT_KEYWORDS="amd64"
ACCEPT_LICENSE="* -@EULA"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=core2 -O2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/env.d/java/ /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-march=core2 -O2 -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="assume-digests binpkg-logs distlocks fixlafiles fixpackages news parallel-fetch protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch"
GENTOO_MIRRORS="http://ftp.uni-erlangen.de/pub/mirrors/gentoo http://ftp.snt.utwente.nl/pub/os/linux/gentoo ftp://ftp.df.lth.se/pub/gentoo/ "
LANG="en_US.UTF-8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
MAKEOPTS="-j3"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
SYNC="rsync://rsync.europe.gentoo.org/gentoo-portage"
USE="X a52 aac acl acpi alsa amd64 berkdb bluetooth bzip2 cairo cdr cli consolekit cracklib crypt cups cursors cxx dbus dri dts dvd dvdr eds emboss encode evo exif faac fam fat ffmpeg firefox flac fortran gdbm gdm gdu gif gnome gnome-keyring gpm gstreamer gtk hal icons iconv ipv6 jpeg lcms ldap libnotify mad mikmod mmx mmxext mng modules mp3 mp4 mpeg mplayer mudflap multilib nautilus ncurses networkmanager nls nokia nptl nptlonly ntfs ogg opengl openmp pam pango pcre pdf perl png policykit ppds pppd python qt-static readline sdl session spell sse sse2 ssl ssse3 startup-notification svg sysfs tcpd theora threads tiff truetype udev unicode usb vaapi vorbis x264 xcb xml xorg xulrunner xv xvid zlib" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ubx" INPUT_DEVICES="evdev synaptics" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" PHP_TARGETS="php5-3" RUBY_TARGETS="ruby18" USERLAND="GNU" VIDEO_CARDS="intel" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account" 
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, FFLAGS, INSTALL_MASK, LC_ALL, LINGUAS, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, PORTDIR_OVERLAY
Comment 4 gary artim 2011-01-09 02:09:17 UTC
needed the same patches, what keeps them from being added upstream? second round for me applied different set for 2.6.34-r12.

gartim@bento ~ $ emerge --info xf86-input-synaptics
Portage 2.1.9.25 (default/linux/amd64/10.0/desktop, gcc-4.4.4, glibc-2.11.2-r3, 2.6.36-gentoo-r5 x86_64)
=================================================================
                        System Settings
=================================================================
System uname: Linux-2.6.36-gentoo-r5-x86_64-Intel-R-_Core-TM-_i5_CPU_M_560_@_2.67GHz-with-gentoo-1.12.14
Timestamp of tree: Sat, 08 Jan 2011 04:45:01 +0000
app-shells/bash:     4.1_p7
dev-lang/python:     2.6.6-r1, 3.1.2-r4
dev-util/cmake:      2.8.1-r2
sys-apps/baselayout: 1.12.14-r1
sys-apps/sandbox:    2.4
sys-devesys-devel/automake:  1.9.6-r3, 1.10.3, 1.11.1
sys-devel/binutils:  2.20.1-r1
sys-devel/gcc:       4.4.4-r2
sys-devel/gcc-config: 1.4.1
sys-devel/libtool:   2.2.10
sys-devel/make:      3.81-r2
virtual/os-headers:  2.6.30-r1 (sys-kernel/linux-headers)
ACCEPT_KEYWORDS="amd64"
ACCEPT_LICENSE="* -@EULA AdobeFlash-10.1 AdobeFlash-10"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=core2 -O4 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/config"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-march=core2 -O4 -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="assume-digests binpkg-logs distlocks fixlafiles fixpackages news parallel-fetch protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch"
GENTOO_MIRRORS="http://gentoo.osuosl.org/ ftp://gentoo.mirrors.tds.net/gentoo rsync://gentoo.mirrors.tds.net/gentoo http://gentoo.mirrors.tds.net/gentoo http://ftp.ucsb.edu/pub/mirrors/linux/gentoo/"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
MAKEOPTS="-j2"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
SYNC="rsync://rsync26.us.gentoo.org/gentoo-portage"
USE="X a52 aac acl acpi alsa amd64 berkdb bluetooth branding bzip2 cairo cdr cli consolekit cracklib crypt cups cxx dbus divx dri dts dvd dvdr emboss encode exif extras fam firefox flac fortran gdbm gdu gif gmedia gpm gtk hal iconv ipv6 jpeg kde lcms ldap libnotify mad mikmod mmx mng modules mp3 mp4 mpeg mudflap multilib ncurses nls nptl nptlonly nsplugin ogg opengl openmp pam pango pcre pdf perl png policykit ppds pppd python qt3support qt4 quicktime readline realmedia sdl session spell sqlite sse sse2 ssl startup-notification svg sysfs tcpd tiff truetype udev unicode usb vorbis wav wifi wma wmp x264 xcb xml xorg xulrunner xv xvid zlib" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ubx" INPUT_DEVICES="evdev synaptics mouse" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" PHP_TARGETS="php5-3" RUBY_TARGETS="ruby18" USERLAND="GNU" VIDEO_CARDS="radeon i915 vesa intel" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account" 
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, FFLAGS, INSTALL_MASK, LANG, LC_ALL, LINGUAS, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, PORTDIR_OVERLAY
l/autoconf:  2.13, 2.65-r1
Comment 5 Gilles Dartiguelongue gentoo-dev 2011-01-10 10:00:07 UTC
*** Bug 350620 has been marked as a duplicate of this bug. ***
Comment 6 Fabian Di Milia 2011-01-11 03:48:13 UTC
Same problem here  with my HP Pavilion DV7-4050z.

The patch works for me... pls add it :)
Comment 7 Maciej Gierok 2011-03-18 08:27:16 UTC
Any chance to port it to xf86-input-synaptics-1.4.0, where problem still occure?
Comment 8 Fabian Di Milia 2011-03-18 09:46:25 UTC
Yeah, the same problem still exist in 1.4.0 :/
Comment 9 Yu Yuwei 2011-03-21 06:56:09 UTC
The patch can be used against 1.4.0, but I don't have a clickpad to test now, maybe someone can test it :)
Comment 10 yetist 2011-03-26 02:12:11 UTC
Created attachment 267223 [details, diff]
xf86-input-synaptics-clickpat-1.4.0.patch

in xf86-input-synaptics, the struct LocalDevicePtr has changed to InputInfoPtr, so I ported this patch to xf86-input-synaptics-1.4.0.
Comment 11 Maciej Gierok 2011-03-26 08:17:09 UTC
(In reply to comment #10)
> Created attachment 267223 [details, diff]
> xf86-input-synaptics-clickpat-1.4.0.patch
> 
> in xf86-input-synaptics, the struct LocalDevicePtr has changed to InputInfoPtr,
> so I ported this patch to xf86-input-synaptics-1.4.0.

Works for me. Thanks. Any chance to add this patch to portage?
Comment 12 Maciej Gierok 2011-04-02 16:32:07 UTC
It is possible to make use of clickpad LED (top-left corner). Here http://pastebin.com/4J3m9WND I found a patch for synaptics 1.4.0. It also required patch for kernel (2.6.38) http://pastebin.com/KB5Q662T Kernel patch work without any changes with gentoo-sources 2.6.38-r1, but synaptics patch need some changes to work with xf86-input-synaptics-clickpat-1.4.0.patch. Could someone help?
Comment 13 David J Cozatt 2011-07-29 02:28:57 UTC
https://bugs.freedesktop.org/show_bug.cgi?id=23890 much smaller patch for touchpad issue.