Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 338414

Summary: app-portage/conf-update-1.0-r1 stable request
Product: Gentoo Linux Reporter: Jan Psota <jasiupsota>
Component: [OLD] Core systemAssignee: Portage Tools Team <tools-portage>
Status: RESOLVED FIXED    
Severity: critical CC: nimiux, sping, torsten, zima
Priority: High Keywords: STABLEREQ
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 339487    
Attachments: conf-update patch
ebuild patch

Description Jan Psota 2010-09-23 07:21:15 UTC
All in summary. Patches included.
Maybe ebuild should be simplified with higher EAPI?
Comment 1 Jan Psota 2010-09-23 07:22:34 UTC
Created attachment 248426 [details, diff]
conf-update patch
Comment 2 Jan Psota 2010-09-23 07:22:55 UTC
Created attachment 248428 [details, diff]
ebuild patch
Comment 3 Jan Psota 2010-09-24 20:09:48 UTC
Oh! I forgot to write why it is important! It is, because conf-update replaces all config files with new ones without prompting when using grep-2.7
Comment 4 Torsten Kurbad 2010-09-28 10:57:06 UTC
(In reply to comment #3)
> It is, because conf-update replaces
> all config files with new ones without prompting when using grep-2.7

Yes, that is exactly what happened to me yesterday... ;-(

Thanks for the fix!

Torsten
Comment 5 Petr Zima 2010-10-03 19:27:25 UTC
The patch works for me too, thanks. Fortunately just *one* config file got mistakenly replaced for me.
Comment 6 Sebastian Pipping gentoo-dev 2010-10-04 19:29:35 UTC
Patch looks sane to me. I'll dare applying. Thanks for the patch and for testing!

+*conf-update-1.0-r1 (04 Oct 2010)
+
+  04 Oct 2010; Sebastian Pipping <sping@gentoo.org>
+  +conf-update-1.0-r1.ebuild, +files/conf-update-1.0-regex-classes.patch:
+  Integrate Jan Psota's regex patch ("[:space:]" to "[[:space:]]") from bug
+  #338414
+

Raising to critical and converting into a stable request to..
- get more QA eyes on it
- push this fix to everyone soon

Old title was:
  app-portage/conf-update-1.0 is not grep-2.7 compatible because of [:space:]
Comment 7 Andreas Schürch gentoo-dev 2010-10-07 14:11:15 UTC
All tests passed successful here on x86.
Comment 8 Markos Chandras (RETIRED) gentoo-dev 2010-10-09 19:01:11 UTC
amd64 done
Comment 9 Christian Faulhammer (RETIRED) gentoo-dev 2010-10-09 19:21:04 UTC
stable x86, thanks Andreas
Comment 10 Sebastian Pipping gentoo-dev 2010-10-22 18:54:55 UTC
PING alpha, pcc

rather urgent in my eyes as grep-2.7 is stable on both of these.


Comment 11 Raúl Porcel (RETIRED) gentoo-dev 2010-12-05 18:05:56 UTC
alpha stable
Comment 12 Brent Baude (RETIRED) gentoo-dev 2011-01-09 14:28:36 UTC
ppc done; closing as last arch