Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 338161

Summary: app-accessibility/brltty-4.1 does not respect LDFLAGS
Product: Gentoo Linux Reporter: Diego Elio Pettenò (RETIRED) <flameeyes>
Component: Current packagesAssignee: William Hubbs <williamh>
Status: RESOLVED FIXED    
Severity: QA CC: accessibility, esigra
Priority: High    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 331933, 358503    
Attachments: Build log
brltty-4.2-fix-ldflags.patch
build.log

Description Diego Elio Pettenò (RETIRED) gentoo-dev 2010-09-20 11:35:17 UTC
See attached build log.

(Please do not complain about the need for looking at the build log until you can provide an easy way to open bugs with the correct data picked out of a tinderbox log. Thanks.)
Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev 2010-09-20 11:35:34 UTC
Created attachment 248126 [details]
Build log
Comment 2 William Hubbs gentoo-dev 2011-03-12 16:01:25 UTC
I believe this is fixedin 4.2, please re-open if it isn't.

Thanks,

William
Comment 3 William Hubbs gentoo-dev 2011-03-12 16:13:11 UTC
My attempt to change the state with pybugz failed.

I see that the build log for this bug was for brltty-4.1, is it still an issue with 4.2?

Thanks,

William
Comment 4 Christopher Brannon (RETIRED) gentoo-dev 2011-03-27 12:22:56 UTC
Created attachment 267387 [details, diff]
brltty-4.2-fix-ldflags.patch

Fixes the LDFLAGS issue for brltty-4.2.
This patch may not be suitable for upstream.
It will work for other Linuxes (?Linuxen?), and it might even work for the
BSDs.  But I don't know anything about the many other platforms supported
by brltty.
Comment 5 William Hubbs gentoo-dev 2011-03-28 21:27:30 UTC
This patch has been added to the tree, thanks much, please be sure to send it upstream.
Comment 6 William Hubbs gentoo-dev 2011-03-29 03:11:45 UTC
I am reopening this bug.

I just attempted to emerge brltty-4.2 again and it failed. I will attach
the build log.
Comment 7 William Hubbs gentoo-dev 2011-03-29 03:13:22 UTC
Created attachment 267623 [details]
build.log

build log
Comment 8 William Hubbs gentoo-dev 2011-03-29 19:55:31 UTC
This is fixed.

eautoreconf was running autoheader, which was breaking the build since
brltty doesn't use all of the autotools. I reworked the ebuild to use
eautoconf instead.