| Summary: | sci-libs/clapack-3.2.1-r3 ebuild is completely false | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Samuli Suominen (RETIRED) <ssuominen> |
| Component: | Current packages | Assignee: | Gentoo Science Related Packages <sci> |
| Status: | RESOLVED FIXED | ||
| Severity: | QA | CC: | kde, qa |
| Priority: | High | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
|
Description
Samuli Suominen (RETIRED)
2010-09-18 22:08:10 UTC
Futhermore bash assigment doesn't need quoting:
S="${WORKDIR}/${P}-CMAKE"
should be
S=${WORKDIR}/${P}-CMAKE
Futhermore I'm not convinced the cmake-utils_use_enable's are working at all, given the flag is -DBUILD_TESTING instead of -DENABLE_TESTS Not sure on the static-libs one either, unless it's a cmake internal thing, certainly the provided build system doesn't export one > The \ should be dropped from: > mycmakeargs=( \ Fixed. > And IUSE is missing both "test" and "static-libs" Done for "test". > Futhermore bash assigment doesn't need quoting: > S=${WORKDIR}/${P}-CMAKE Done > Futhermore I'm not convinced the cmake-utils_use_enable's are working at all, > given the flag is -DBUILD_TESTING instead of -DENABLE_TESTS That definitely is correct since I wrote the IF's myself. Maybe just a bit too complicated. > Not sure on the static-libs one either, unless it's a cmake internal thing, > certainly the provided build system doesn't export one That's not correct, since there is indeed no static lib target. Removed. |
