Bug 334649

Summary:	dev-scheme/tinyscheme does not respect LDFLAGS
Product:	Gentoo Linux	Reporter:	Diego Elio Pettenò (RETIRED) <flameeyes>
Component:	New packages	Assignee:	Scheme Project <scheme>
Status:	RESOLVED FIXED
Severity:	QA	CC:	esigra, gentoo, scheme
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	331933
Attachments:	Build log Ebuild respecting LDFLAGS Patch for tinyscheme-1.39-r1

Description Diego Elio Pettenò (RETIRED) gentoo-dev

2010-08-26 14:56:58 UTC

See attached build log.

(Please do not complain about the need for looking at the build log until you can provide an easy way to open bugs with the correct data picked out of a tinderbox log. Thanks.)

Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev

2010-08-26 14:57:10 UTC

Created attachment 244751 [details]
Build log

Comment 2 Nick White 2010-11-27 12:01:24 UTC

Created attachment 255571 [details]
Ebuild respecting LDFLAGS

Good ol' tinderbox.

Attached is a patch adding a sed rule to ensure that we properly respect LDFLAGS.

Comment 3 Marijn Schouten (RETIRED) gentoo-dev

2011-02-24 14:28:40 UTC

Hey Nick, can you create a patch against 1.39-r1?

Comment 4 Cyprien Nicolas (fulax) 2011-02-24 16:47:19 UTC

There is the tinyscheme-1.39-r2 ebuild in the lisp overlay, which fix this bug along with bug 328967.

The difference between the proposed fixed here and the one in the overlay is whether the ${LDFLAGS} variable should be put at the end, or at the beginning of the gcc command line.

Comment 5 Nick White 2011-02-24 18:21:50 UTC

Created attachment 263705 [details, diff]
Patch for tinyscheme-1.39-r1 

Here ya go.

Comment 6 Marijn Schouten (RETIRED) gentoo-dev

2011-02-28 16:47:28 UTC

Please test 1.40 and let me know if the problem persists.

Comment 7 Nick White 2011-05-11 23:07:26 UTC

(In reply to comment #6)
> Please test 1.40 and let me know if the problem persists.

Nope, it's all fixed with 1.40, this bug should be closed resolved.

Comment 8 Cyprien Nicolas (fulax) 2011-05-13 11:57:02 UTC

Closing then, thanks for the report.

Comment 9 Agostino Sarubbo gentoo-dev

2013-02-03 15:57:45 UTC

with 1.40 I get:

 * QA Notice: Files built without respecting LDFLAGS have been detected
 *  Please include the following list of files in your report:
 * /usr/bin/tinyscheme

Comment 10 Panagiotis Christopoulos (RETIRED) gentoo-dev

2013-12-11 13:38:07 UTC

*tinyscheme-1.41 (11 Dec 2013)

  11 Dec 2013; Panagiotis Christopoulos <pchrist@gentoo.org>
  +tinyscheme-1.41.ebuild, +files/tinyscheme-1.41-makefile.patch:
  Bump to 1.41 contains various fixes for bug #334649, bug #455294, bug
  #455296, bug #455298, bug #455300 and bug #493694, thanks to Agostino Sarubbo
  (ago at gentoo dot org) for reporting the QA issues. Special thanks to
  Michael Mair-Keimberger (iamnr3) who made the patches in bug #455296. Prefix
  (darwin) keywords dropped cause logic inside the ebuild has changed and the
  ebuild needs rekeywording.

I'll close this when 1.41 is stabilized, removing old versions.