Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 334631

Summary: sys-block/disktype does not respect LDFLAGS
Product: Gentoo Linux Reporter: Diego Elio Pettenò (RETIRED) <flameeyes>
Component: New packagesAssignee: Forensics Herd [disbanded] <forensics+obsolete>
Severity: QA CC: esigra
Priority: High    
Version: unspecified   
Hardware: All   
OS: Linux   
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 331933    
Attachments: Build log
Patch to disktype-9.ebuild to use emake and to respect LDFLAGS

Description Diego Elio Pettenò (RETIRED) gentoo-dev 2010-08-26 14:52:11 UTC
See attached build log.

(Please do not complain about the need for looking at the build log until you can provide an easy way to open bugs with the correct data picked out of a tinderbox log. Thanks.)
Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev 2010-08-26 14:52:22 UTC
Created attachment 244733 [details]
Build log
Comment 2 Kevin Pyle 2010-08-26 21:02:45 UTC
Created attachment 244787 [details, diff]
Patch to disktype-9.ebuild to use emake and to respect LDFLAGS

The upstream Makefile explicitly sets LDFLAGS to nothing and CFLAGS to a fixed value.  Since the Gentoo ebuild already sets CC= and CFLAGS= on the make command line, this patch follows the same approach by also setting LDFLAGS via the make command line.  This patch also switches to emake, since the upstream build system seems to be parallel safe.  I built with MAKEOPTS=-j on a 4-core machine with no problem and the Makefile looks correct.
Comment 3 Tim Harder gentoo-dev 2011-09-28 00:53:28 UTC
Fixed in CVS.