Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 334603

Summary: net-mail/mess822 does not respect LDFLAGS
Product: Gentoo Linux Reporter: Diego Elio Pettenò (RETIRED) <flameeyes>
Component: New packagesAssignee: Net-Mail Packages <net-mail+disabled>
Severity: QA CC: esigra
Priority: High    
Version: unspecified   
Hardware: All   
OS: Linux   
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 331933    
Attachments: Build log
Patch to mess822-0.58-r1.ebuild to modernize the build system and respect LDFLAGS along the way

Description Diego Elio Pettenò (RETIRED) gentoo-dev 2010-08-26 14:43:29 UTC
See attached build log.

(Please do not complain about the need for looking at the build log until you can provide an easy way to open bugs with the correct data picked out of a tinderbox log. Thanks.)
Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev 2010-08-26 14:43:42 UTC
Created attachment 244707 [details]
Build log
Comment 2 Kevin Pyle 2010-08-29 00:20:18 UTC
Created attachment 245181 [details, diff]
Patch to mess822-0.58-r1.ebuild to modernize the build system and respect LDFLAGS along the way

This was a bigger task than I expected going in.  Upstream used custom thin wrappers to run the compiler, linker, and ar.  Also, the make process itself tries to discover various system properties by building and running test programs.  This has nasty consequences for cross-compilation, so I decided to fix that too.  As a nice side effect, the build log is now informative since the commands are printed instead of just "./compile FILE", etc..  (The install phase is also done via a custom built application just for installing.  That is left for another day.)

This patch addresses the following issues:
- Respect $LDFLAGS by converting link rules (originally done via ./load) to use Make's LINK.o variable.
- Respect $CPPFLAGS by using COMPILE.c (originally done via ./compile).
- Fix bad manual definition of read and write by replacing that header with an inclusion of <unistd.h>.
- Drop all the system inspection helpers in favor of manually creating the outputs they would have done.  As best I can tell, everything they seek is specified in POSIX.1-2001, so it turned out to be nothing more than a series of one line headers that #include standard system headers.
- Fix conflicting definition of a package local function named 'puts' with different semantics than system puts, by renaming package local puts to avoid_system_puts.
Comment 3 Eray Aslan gentoo-dev 2011-06-06 14:40:04 UTC
+*mess822-0.58-r2 (06 Jun 2011)
+  06 Jun 2011; Eray Aslan <> +mess822-0.58-r2.ebuild,
+  +files/mess822-0.58-implicit.patch:
+  Respect CFLAGS - bug #241056. Respect LDFLAGS - bug #334603. Restrict test -
+  bug #283172