Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 334599

Summary: app-arch/pure-sfv does not respect LDFLAGS
Product: Gentoo Linux Reporter: Diego Elio Pettenò (RETIRED) <flameeyes>
Component: New packagesAssignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it <maintainer-needed>
Status: RESOLVED DUPLICATE    
Severity: QA CC: gaurdro, jer
Priority: High    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 331933    
Attachments: Build log
ebuild that applies the ld flag patch
fix the makefile to respect ldflags

Description Diego Elio Pettenò (RETIRED) gentoo-dev 2010-08-26 14:42:24 UTC
See attached build log.

(Please do not complain about the need for looking at the build log until you can provide an easy way to open bugs with the correct data picked out of a tinderbox log. Thanks.)
Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev 2010-08-26 14:42:37 UTC
Created attachment 244703 [details]
Build log
Comment 2 Ross Smith 2010-08-27 02:37:12 UTC
Created attachment 244837 [details]
ebuild that applies the ld flag patch
Comment 3 Ross Smith 2010-08-27 02:37:47 UTC
Created attachment 244839 [details, diff]
fix the makefile to respect ldflags
Comment 4 Jeroen Roovers (RETIRED) gentoo-dev 2010-08-27 05:45:04 UTC
Had to go and actually patch the previous --as-needed patch. I don't know how that would have worked. Fixed in -r1.

Index: files/pure-sfv-0.3-asneeded.patch
===================================================================
RCS file: /var/cvsroot/gentoo-x86/app-arch/pure-sfv/files/pure-sfv-0.3-asneeded.patch,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -B -r1.1 -r1.2
--- files/pure-sfv-0.3-asneeded.patch   3 Jan 2009 17:39:34 -0000       1.1
+++ files/pure-sfv-0.3-asneeded.patch   27 Aug 2010 05:43:29 -0000      1.2
@@ -5,7 +5,7 @@
  
  pure-sfv: $(OBJ)
 -      $(CC) -lm -DVERSION=\"$(VERSION)\" $(CFLAGS) -o $(PROG) $(OBJ)
-+      $(CC) -DVERSION=\"$(VERSION)\" $(CFLAGS) -o $(PROG) $(OBJ) -lm
++      $(CC) -DVERSION=\"$(VERSION)\" $(CFLAGS) $(LDFLAGS) -o $(PROG) $(OBJ) -lm
  
  PURIFY_OPTIONS=-follow-child-processes=yes -always-use-cache-dir=yes
  PURIFY=purify

*** This bug has been marked as a duplicate of bug 246858 ***