Bug 334577

Summary:	app-misc/vcp does not respect LDFLAGS
Product:	Gentoo Linux	Reporter:	Diego Elio Pettenò (RETIRED) <flameeyes>
Component:	New packages	Assignee:	Gentoo Shell Tools project <shell-tools>
Status:	RESOLVED FIXED
Severity:	QA	CC:	gaurdro, jer
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	331933
Attachments:	Build log ebuild that applies the patch to fix LD flags. patch to fix ldflags

Description Diego Elio Pettenò (RETIRED) gentoo-dev

2010-08-26 14:35:08 UTC

See attached build log.

(Please do not complain about the need for looking at the build log until you can provide an easy way to open bugs with the correct data picked out of a tinderbox log. Thanks.)

Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev

2010-08-26 14:35:36 UTC

Created attachment 244681 [details]
Build log

Comment 2 Ross Smith 2010-08-27 01:18:52 UTC

Created attachment 244827 [details]
ebuild that applies the patch to fix LD flags.

Comment 3 Ross Smith 2010-08-27 01:19:27 UTC

Created attachment 244829 [details, diff]
patch to fix ldflags

Comment 4 Jeroen Roovers (RETIRED) gentoo-dev

2010-08-27 05:26:40 UTC

Thanks for the patch. I ended up implementing it as a sed script, in -r1.

Comment 5 Kevin Pyle 2010-08-27 05:27:58 UTC

(In reply to comment #2)
> Created an attachment (id=244827) [details]
> ebuild that applies the patch to fix LD flags.

For future reference, I have found that many of the maintainers prefer to receive a patch for the ebuild, rather than a complete copy of the adjusted ebuild.  This allows them to easily merge your fix with any other proposed changes to the same ebuild, and is particularly convenient if the ebuild receives unrelated changes before your proposed patch is examined.