Summary: | support file:// in SRC_URI | ||
---|---|---|---|
Product: | Gentoo Hosted Projects | Reporter: | Helmut Jarausch <jarausch> |
Component: | PMS/EAPI | Assignee: | PMS/EAPI <pms> |
Status: | RESOLVED NEEDINFO | ||
Severity: | enhancement | CC: | a.m, esigra, ssuominen |
Priority: | Low | Keywords: | NeedPatch |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 174380, 391439 |
Description
Helmut Jarausch
2010-08-24 12:08:35 UTC
is there a reason this you can't use RESTRICT=mirror, and symlink the distfile into $DISTDIR ? That accomplishes the same... personally I don't like file:/// in an ebuild since it should be specifying the remote location, not used to avoid existing DISTDIR tricks... i don't think we should be restricting supported URI's based on "can these be used in the tree". people write local/internal ebuilds all the time, and their own circumstances don't always lend themselves to flexibility. the file:// URI spec is fairly well understood and should be trivial to support. (In reply to comment #2) > i don't think we should be restricting supported URI's based on "can these be > used in the tree". people write local/internal ebuilds all the time, and their > own circumstances don't always lend themselves to flexibility. > > the file:// URI spec is fairly well understood and should be trivial to > support. Doesn't seem like a candidate for PMS to me. Rather Portage-specific feature. Brian is fairly intent on these not being portage specific, and i see no reason to keep this out of PMS There's no way for an ebuild to use these correctly, though. We shouldn't be specifying things that have no legitimate use. (In reply to comment #4) > Brian is fairly intent on these not being portage specific, and i see no reason > to keep this out of PMS I see PMS as an intent to keep ebuilds portable. Ebuilds relying on local paths can't be portable by definition. There's no point in PMS saying about those. yes, portable *across package managers*. there is no (nor should there be any) restriction on what's supported based on "is this in the main Gentoo portage tree". Well, you still can write something like: src_unpack() { unpack /usr/local/.... } which seems to be cleaner than 'fetching' a local file. (In reply to Michał Górny from comment #8) > you still can write something like: > > src_unpack() { > unpack /usr/local/.... /usr/lib/portage/bin/phase-helpers.sh: unpack() { ... elif [[ ${x} == "/"* ]] ; then die "Arguments to unpack() cannot be absolute" Oh, I see that 'unpack' is non-intuitive and braindead by design... (In reply to Michał Górny from comment #8) > Well, you still can write something like: > > src_unpack() { > unpack /usr/local/.... > } > > which seems to be cleaner than 'fetching' a local file. No. Things in SRC_URI get proper digest checksums in Manifest, unpack on random paths doesn't. This may have security implications, too. (In reply to SpanKY from comment #2) > i don't think we should be restricting supported URI's based on "can these > be used in the tree". people write local/internal ebuilds all the time, and > their own circumstances don't always lend themselves to flexibility. > > the file:// URI spec is fairly well understood and should be trivial to > support. I tend to agree with Mike. "file" is a standard scheme (described in RFC 1738), and implementation should be trivial. Supporting it in SRC_URI is cleaner than bypassing fetch (and checksum verification) via src_unpack tricks. Of course it cannot be used in the tree. If someone cares enough to provide a patch for Portage, then I'll add this to the list of tentative features for the next EAPI. No reply for almost a year. Assuming interest was lost (or never were high enough to bring a patch :)). This is an unintrusive feature, and I don't see why it shouldn't be added to the spec, provided that there will be an implementation. The NeedPatch keyword is set, so I don't see any need to close this bug. *** Bug 553768 has been marked as a duplicate of this bug. *** No progress since 3 years. Closing. |