Bug 333811

Summary:	net-misc/ipsorcery does not respect LDFLAGS
Product:	Gentoo Linux	Reporter:	Diego Elio Pettenò (RETIRED) <flameeyes>
Component:	New packages	Assignee:	Daniel Black (RETIRED) <dragonheart>
Status:	RESOLVED FIXED
Severity:	QA
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	331933
Attachments:	Build log Patch to ipsorcery-2.0.9.ebuild to address various QA issues

Description Diego Elio Pettenò (RETIRED) gentoo-dev

2010-08-21 15:28:58 UTC

See attached build log.

(Please do not complain about the need for looking at the build log until you can provide an easy way to open bugs with the correct data picked out of a tinderbox log. Thanks.)

Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev

2010-08-21 15:35:02 UTC

Created attachment 243877 [details]
Build log

Comment 2 Markos Chandras (RETIRED) gentoo-dev

2010-08-21 19:13:43 UTC

+*ipsorcery-2.0.9-r1 (21 Aug 2010)
+
+  21 Aug 2010; Markos Chandras <hwoarang@gentoo.org>
+  +ipsorcery-2.0.9-r1.ebuild:
+  Respect CC,CFLAGS,LDFLAGS. Bug #333811. Thanks to Diego E. 'Flameeyes'
+  Pettenò <flameeyes@gentoo.org> for reporting. Keyworded for amd64
+

Comment 3 Kevin Pyle 2010-08-21 20:43:59 UTC

Created attachment 243957 [details, diff]
Patch to ipsorcery-2.0.9.ebuild to address various QA issues

This package had several problems:

- CC=cc
- Ignored CPPFLAGS (minor)
- Ignored LDFLAGS
- Non-GTK build used make, rather than emake.
- Use of dosbin without ||die

This patch addresses these problems by:
- Deleting the CC= line, inheriting toolchain-funcs, and exporting CC
- Adding CPPFLAGS and LDFLAGS alongside the CFLAGS already added by the ebuild
- Switching to emake
- Adding ||die to dosbin calls

Also, of minor interest, the package is not keyworded for amd64, but it built correctly for me on a stable amd64 system.  However, it has no self tests, and I am not in a position to test using the program in a live environment.

Comment 4 Kevin Pyle 2010-08-21 20:45:39 UTC

Weird.  I did not get a collision alert when I posted my patch, and comment #2 was not visible when I started work on this.  Oh well.