Summary: | dev-libs/openssl-1.0.0a-r1 has armv4 optimizations, but gentoo.config does not respect them | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Sergei Trofimovich (RETIRED) <slyfox> |
Component: | New packages | Assignee: | Gentoo's Team for Core System packages <base-system> |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
gentoo-config.patch - adds armv4+ targets as special
openss-ebuild.patch - just changes gentoo.config name |
Description
Sergei Trofimovich (RETIRED)
2010-08-20 19:18:39 UTC
Created attachment 243747 [details, diff]
gentoo-config.patch - adds armv4+ targets as special
Created attachment 243749 [details, diff]
openss-ebuild.patch - just changes gentoo.config name
looks fine, but there would be issues with arm-* targets thinking about it some more, i think it'll get other targets incorrect as well. for example, arm6-xxx probably means the ARM6 family which is of the architecture ARMv3. the ARM naming convention is just way too f-ed up to make this an "opt-out" glob. perhaps the only safe way to handle this is: + armv[4-9]*b*) machine="armv4 -DB_ENDIAN";; + armv[4-9]*) machine="armv4 -DL_ENDIAN";; + arm*b*) machine="generic32 -DB_ENDIAN";; + arm*) machine="generic32 -DL_ENDIAN";; the openssl config itself does the opposite, but they're comparing against `uname -m`, so they can trust the output a lot more than we can. if this change works for your circumstances, i'll go ahead and commit it (In reply to comment #4) > thinking about it some more, i think it'll get other targets incorrect as well. > for example, arm6-xxx probably means the ARM6 family which is of the > architecture ARMv3. the ARM naming convention is just way too f-ed up to make > this an "opt-out" glob. Ugh, I messed things even worse in initial patch then. > perhaps the only safe way to handle this is: > + armv[4-9]*b*) machine="armv4 -DB_ENDIAN";; > + armv[4-9]*) machine="armv4 -DL_ENDIAN";; > + arm*b*) machine="generic32 -DB_ENDIAN";; > + arm*) machine="generic32 -DL_ENDIAN";; > > the openssl config itself does the opposite, but they're comparing against > `uname -m`, so they can trust the output a lot more than we can. > > if this change works for your circumstances, i'll go ahead and commit it > Yes, it works: Operating system: armv5tel-whatever-linux2 Configuring for linux-armv4 * Use configuration linux-armv4 -DL_ENDIAN i glanced through the source and noticed that there also seems to be a new s390x target, so i added that on top of bfin/avr and these arm changes. thanks for testing. |