Bug 333515

Summary:	x11-misc/idesk-0.7.5-r1 fails to build with glibc-2.12 due to missing sys/stat.h include
Product:	Gentoo Linux	Reporter:	Charlie Gehlin <charlie>
Component:	New packages	Assignee:	Desktop Misc. Team <desktop-misc>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	High
Version:	unspecified
Hardware:	AMD64
OS:	Linux
URL:	http://launchpadlibrarian.net/50127310/idesk_ftbfs.diff
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	331665
Attachments:	idesk_ftbfs.diff

Description Charlie Gehlin 2010-08-19 21:34:38 UTC

DesktopConfig.cpp:134: error: no matching function for call to 'stat::stat(const char*, stat*)'

Reproducible: Always

Actual Results:  
x86_64-pc-linux-gnu-g++ -DHAVE_CONFIG_H -I. -I. -I.. -I..    -march=nocona -mmmx -msse -msse2 -msse3 -O2 -pipe  -DSHAPE  -I/usr/include/startup-notification-1.0   -DHAVE_STARTUP_NOTIFICATION -DSN_API_NOT_YET_FROZEN=1, -I/usr/include/freetype2   -c DesktopConfig.cpp
DesktopConfig.cpp: In member function 'virtual void DesktopConfig::setDesktopOnlyOptions(Table)':
DesktopConfig.cpp:134: error: no matching function for call to 'stat::stat(const char*, stat*)'



Will attach patch that works in my local overlay

Comment 1 Charlie Gehlin 2010-08-19 21:35:11 UTC

Created attachment 243623 [details, diff]
idesk_ftbfs.diff

Comment 2 Diego Elio Pettenò (RETIRED) gentoo-dev

2010-08-19 21:50:50 UTC

Please, next time provide emerge --info, and state the complete package name, as not everybody know them by heart ^^

Not that this failure is a mystery for anybody.

Comment 3 SpanKY gentoo-dev

2010-08-19 23:07:14 UTC

upstream URL has this patch:

--- idesk-0.7.5.orig/src/DesktopConfig.cpp
+++ idesk-0.7.5/src/DesktopConfig.cpp
@@ -24,6 +24,8 @@
 
 #include "DesktopConfig.h"
 #include "Util.h"
+#include <sys/types.h>    // For stat()
+#include <sys/stat.h>     // For stat()
 
 //the initilizer list just sets the program defaults for non-necessary options
 DesktopConfig::DesktopConfig(Database db, string ideskrcFile) :

Comment 4 Kacper Kowalik (Xarthisius) (RETIRED) gentoo-dev

2010-08-20 07:31:29 UTC

+*idesk-0.7.5-r2 (20 Aug 2010)
+
+  20 Aug 2010; Kacper Kowalik <xarthisius@gentoo.org>
+  +idesk-0.7.5-r2.ebuild, +files/idesk-0.7.5-glibc-2.12.patch:
+  Fix building with GLIBC 2.12 wrt bug 333151. Thanks to Charlie Gehlin
+  <charlie@gehlin.com> for report and scavenging patch.
+