Bug 333469

Summary:	gnome-extra/libgda configure script does not process some explicit with flags
Product:	Gentoo Linux	Reporter:	Michal Kurgan <moloh>
Component:	New packages	Assignee:	Gentoo Linux Gnome Desktop Team <gnome>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	libgda-4.1.4-configure-with-yes-checks.patch libgda-4.1.4-r1.ebuild.patch config.log emerge.info

Description Michal Kurgan 2010-08-19 17:45:08 UTC

$ sudo emerge libgda -vp
[ebuild   R   ] gnome-extra/libgda-4.1.4-r1  USE="berkdb canvas gtk mysql sourceview -bindist -debug -doc (-firebird) -freetds -graphviz -java -ldap -oci8 -odbc -postgres -xbase"

configure.in script does not have yes portions of AC_ARG_WITH with the result that we explicitly ask for gtksourceview support it is not used, automatic portion still works.

Will attach patch for configure and ebuild shortly. Note that problem is visible with gnome-extra/libgda-4.1.7 too. Maybe we should send patch upstream.

Reproducible: Always

Steps to Reproduce:
1. emerge libgda with +sourceview || +canvas
2.
3.

Actual Results:  
No sourceview or canvas is used in libgda

Expected Results:  
Sourceview or canvas is used in libgda

Comment 1 Michal Kurgan 2010-08-19 17:46:17 UTC

Created attachment 243579 [details]
libgda-4.1.4-configure-with-yes-checks.patch

Patch for configure.in

Comment 2 Michal Kurgan 2010-08-19 17:48:27 UTC

Created attachment 243581 [details, diff]
libgda-4.1.4-r1.ebuild.patch

Patch for ebuild to use configure.in

Comment 3 Michal Kurgan 2010-08-19 17:49:23 UTC

Note that gnome-extra/libgda-4.1.7 renamed configure.in to configure.ac.

Comment 4 Michal Kurgan 2010-08-19 19:46:18 UTC

Submitted: https://bugzilla.gnome.org/show_bug.cgi?id=627421

Comment 5 Gilles Dartiguelongue (RETIRED) gentoo-dev

2010-08-20 09:37:48 UTC

Afaik this is unneeded, AC_ARG_(WITH|ENABLE) defaults to doing this when not supplying something for third argument.

Comment 6 Gilles Dartiguelongue (RETIRED) gentoo-dev

2010-08-20 09:38:05 UTC

emerge --info and config.log please.

Comment 7 Michal Kurgan 2010-08-20 17:35:47 UTC

Created attachment 243723 [details]
config.log

Comment 8 Michal Kurgan 2010-08-20 17:36:14 UTC

Created attachment 243725 [details]
emerge.info

Comment 9 Michal Kurgan 2010-08-20 17:40:10 UTC

(In reply to comment #5)
> Afaik this is unneeded, AC_ARG_(WITH|ENABLE) defaults to doing this when not
> supplying something for third argument.
> 

Yes, with_* are set by default, but here they use different identifiers, i.e.
not with_gtksourceview, but with_sourceview. Your argument stands correct only for graphiz option in the patch, however leaving graphiz and fixing gtksourceview, goocanvas would make another person wonder what is going on there.

Comment 10 Gilles Dartiguelongue (RETIRED) gentoo-dev

2010-08-20 18:11:22 UTC

oh right, they are doing it wrong then, better use the default naming scheme.

Comment 11 Michal Kurgan 2010-08-23 03:54:46 UTC

It would be great to have bump for stable in the tree.
Patch was also applied upstream in master, should show up in 4.1.8.

Comment 12 Pacho Ramos gentoo-dev

2010-09-13 18:11:54 UTC

+*libgda-4.1.10 (13 Sep 2010)
+
+  13 Sep 2010; Pacho Ramos <pacho@gentoo.org> -libgda-4.1.4.ebuild,
+  -libgda-4.1.7.ebuild, +libgda-4.1.10.ebuild:
+  Version bump adding gnome-keyring support and with multiple bugfixes:
+  GdaBrowser improvements & corrections, improved core API, core corrections
+  and optimization, many improvements to the UI extension, many improvements
+  and corrections to the GdaBrowser tool, fix configure issues (bug #333469
+  by Michal Kurgan). Remove old testing.
+