| Summary: | media-libs/mlt does not respect LDFLAGS | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Diego Elio Pettenò (RETIRED) <flameeyes> |
| Component: | New packages | Assignee: | Gentoo Media-video project <media-video> |
| Status: | RESOLVED FIXED | ||
| Severity: | QA | CC: | esigra |
| Priority: | High | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 331933 | ||
| Attachments: | Build log | ||
|
Description
Diego Elio Pettenò (RETIRED)
2010-08-12 19:21:27 UTC
Created attachment 242663 [details]
Build log
The only file which failed to respect LDFLAGS is the Ruby binding. It appears that hwoarang@g.o (tried to) fix this and several other problems. However, as called out by a warning near the top of the build log, a typo prevented the Ruby fix from being effective: 8 * Applying mlt-0.5.4-asneeded.patch ... 9 [ ok ] 10 sed: -e expression #1, char 11: : doesn't want any addresses 11 >>> Source prepared. Checking the ebuild, we see: 67 sed -i "/^LDFLAGS/:s += : &${LDFLAGS} :" src/swig/ruby/build There are two problems here. The serious problem is that the s and the colon were transposed, causing the sed to fail. The minor problem is that neither of the sed calls have an ||die, so the ebuild did not bail out on the failure. sed does exit with an error when it fails to parse the expression cited here, so an ||die would have caught it. Caveat: I have not run the ebuild with the expression fixed, so correcting the sed expression may not be sufficient to produce a perfectly functional ebuild. seems its been fixed during the 0.7.6 bump |