Bug 332479

Summary:	app-arch/par does not respect LDFLAGS
Product:	Gentoo Linux	Reporter:	Diego Elio Pettenò (RETIRED) <flameeyes>
Component:	New packages	Assignee:	Sven Wegener <swegener>
Status:	RESOLVED FIXED
Severity:	QA	CC:	esigra
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	331933
Attachments:	Build log Patch to par-1.1.ebuild to add a sed to fix upstream Makefile

Description Diego Elio Pettenò (RETIRED) gentoo-dev

2010-08-12 16:20:22 UTC

See attached build log.

(Please do not complain about the need for looking at the build log until you can provide an easy way to open bugs with the correct data picked out of a tinderbox log. Thanks.)

Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev

2010-08-12 16:20:34 UTC

Created attachment 242619 [details]
Build log

Comment 2 Kevin Pyle 2010-08-14 04:21:30 UTC

Created attachment 242887 [details, diff]
Patch to par-1.1.ebuild to add a sed to fix upstream Makefile

The upstream Makefile uses an explicit rule to build par:

    $(CC) -o $@ $^

This rule does not include $(LDFLAGS), so the user's LDFLAGS are silently ignored.  The attached patch changes the CC to LINK.o, which is a GNU make built in variable defined as:

LINK.o = $(CC) $(LDFLAGS) $(TARGET_ARCH)

With the patch applied, I see my LDFLAGS applied to par.

Comment 3 Sven Wegener gentoo-dev

2012-11-25 15:32:11 UTC

Thanks, commited.