Summary: | QA Issues with net-analyzer/pnp4nagios-0.6.4 | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Dane Smith (RETIRED) <c1pher> |
Component: | Current packages | Assignee: | Tobias Scherbaum (RETIRED) <dertobi123> |
Status: | RESOLVED FIXED | ||
Severity: | QA | CC: | hwoarang, mabi, netmon, olemarkus, recruiters |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 330539 | ||
Attachments: |
build.log
Diff from pnp4nagios-0.6.4.ebuild src/Makefile.in Patch Makefile.in patch |
Description
Dane Smith (RETIRED)
2010-08-12 15:53:17 UTC
Created attachment 242597 [details]
build.log
Created attachment 242631 [details]
Diff from pnp4nagios-0.6.4.ebuild
Diff from the ebuild in the tree. Changed the install target. Attached both the patches.
Created attachment 242633 [details]
src/Makefile.in Patch
Added LDFLAGS into the npcd target.
Created attachment 242635 [details]
Makefile.in patch
The Makefile.in install-unstripped target calls make install-unstripped in all of the sub-directories. However, the Makefiles SHARE and SCRIPTS do not have such targets. Changed install-unstripped to just call make install in those directories.
I am willing to submit these upstream, but I will wait to hear from the maintainer. I don't want to step on any toes.
Added patches to 0.6.5 as well as some fixes required for PHP 5.3 and commited to the tree as 0.6.5-r1. Seems to be working. (In reply to comment #5) > Added patches to 0.6.5 as well as some fixes required for PHP 5.3 and commited > to the tree as 0.6.5-r1. Seems to be working. > Is not working as important files are no longer installed. re-opening and adding olemarkus@gentoo.org to CC. (In reply to comment #7) > re-opening and adding olemarkus@gentoo.org to CC. > Congrats to breaking stuff and not reacting after all dude. Tumbsup! This is now really fixed in CVS. Looks like this happened within the first month. CCing mentor. Yeah, that's my fault. I only checked the ebuild, sorry for that. Tbh, I wouldn't have caught the error from commit inspection, though. Anyway, won't happen again. That's no excuse but RL kept me fairly occupied last week(s). Btw, I'm confused - I only saw the action in Bug 330539? No idea pnp4nagios was broken that long. Sorry for that oversight, too. OTOH, please be aware that with my RL issues thinning my time for gentoo, Ole is handling all of PHP by himself, which could probably keep half a dozen devs busy. If there's anything you'd like me to do on this bug, I still try to keep up with my (bug)mail.. so just reply :) (In reply to comment #10) > Yeah, that's my fault. I only checked the ebuild, sorry for that. Tbh, I > wouldn't have caught the error from commit inspection, though. > Anyway, won't happen again. That's no excuse but RL kept me fairly occupied > last week(s). Well, basically ... Ebuilds that tend to look good don't necessarily need to work as expected. Therefore it is absolutely required to check what you're changing, what the impacts are and if the result in the end is still working. The openssl patch in Debian for example did look good, but well ... you know the end. Even for QA related stuff (btw. i thought only QA people are allowed to commit QA related stuff?) ... test it or don't commit it. Oh, and *if* you screwed up - then at least revert the changes or fix your commits. Neither has happened. And not reacting for now 14 days ... that's also quite bad. > Btw, I'm confused - I only saw the action in Bug 330539? No idea pnp4nagios was > broken that long. Sorry for that oversight, too. Then you should read this bug again. > OTOH, please be aware that with my RL issues thinning my time for gentoo, Ole > is handling all of PHP by himself, which could probably keep half a dozen devs > busy. Being a mentor and having no time for Gentoo - well that's a combination that's not going to work. Also it isn't that "optimal" to have a new dev being responsible for such important stuff (and especially if his mentor has time constraints). > If there's anything you'd like me to do on this bug, I still try to keep up > with my (bug)mail.. so just reply :) Not sure what to do - that's a recruiters thingy. Adding them therefore. (In reply to comment #11) > > > If there's anything you'd like me to do on this bug, I still try to keep up > > with my (bug)mail.. so just reply :) > > Not sure what to do - that's a recruiters thingy. Adding them therefore. > This bug is not the place for this discussion. We should do it in bug 321263. (In reply to comment #12) > This bug is not the place for this discussion. We should do it in bug 321263. Closing this one therefore. |