Bug 331885

Summary:	www-apache/mod_cband does not respect LDFLAGS
Product:	Gentoo Linux	Reporter:	Diego Elio Pettenò (RETIRED) <flameeyes>
Component:	New packages	Assignee:	Krzysztof Pawlik (RETIRED) <nelchael>
Status:	RESOLVED FIXED
Severity:	QA	CC:	apache-bugs, esigra
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:	335405
Bug Blocks:	331933
Attachments:	Build log

Description Diego Elio Pettenò (RETIRED) gentoo-dev

2010-08-09 16:47:26 UTC

See attached build log.

(Please do not complain about the need for looking at the build log until you can provide an easy way to open bugs with the correct data picked out of a tinderbox log. Thanks.)

Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev

2010-08-09 16:47:42 UTC

Created attachment 242093 [details]
Build log

Comment 2 Krzysztof Pawlik (RETIRED) gentoo-dev

2010-08-19 14:56:54 UTC

mod_cband uses apxs to compile the module binary, following lines are from apxs:

Use of assignment to $[ is deprecated at /usr/sbin/apxs2 line 86.
/usr/bin/libtool --silent --mode=compile x86_64-pc-linux-gnu-gcc -prefer-pic -O2 -pipe -march=core2  -DLINUX=2 -D_REENTRANT -D_GNU_SOURCE -pthread -I/usr/include/apache2  -I/usr/include/apr-1   -I/usr/include/apr-1 -I/usr/include/db4.8 -DDST_CLASS=3  -c -o mod_cband.lo mod_cband.c && touch mod_cband.slo
/usr/bin/libtool --silent --mode=link x86_64-pc-linux-gnu-gcc -o mod_cband.la  -rpath /usr/lib64/apache2/modules -module -avoid-version    mod_cband.lo

Files shipped with mod_cband release tarball are not used much - should apxs be patches instead to respect LDFLAGS or at least apache-module.eclass? (apache-module_src_compile around line 156).

Following patch seems to be working fine for me:

Index: apache-module.eclass
===================================================================
RCS file: /var/cvsroot/gentoo-x86/eclass/apache-module.eclass,v
retrieving revision 1.24
diff -u -r1.24 apache-module.eclass
--- apache-module.eclass        8 Aug 2010 18:46:46 -0000       1.24
+++ apache-module.eclass        19 Aug 2010 14:56:17 -0000
@@ -160,6 +160,7 @@
        cd "${CD_DIR}" || die "cd ${CD_DIR} failed"
 
        APXS2_ARGS="${APXS2_ARGS:--c ${PN}.c}"
+       APXS2_ARGS="${APXS2_ARGS} ${LDFLAGS}"
        ${APXS} ${APXS2_ARGS} || die "${APXS} ${APXS2_ARGS} failed"
 }

Comment 3 Krzysztof Pawlik (RETIRED) gentoo-dev

2011-02-25 20:16:39 UTC

apxs now respects LDFLAGS, see bug #335405.