Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 331877

Summary: app-crypt/rainbowcrack does not respect LDFLAGS
Product: Gentoo Linux Reporter: Diego Elio Pettenò (RETIRED) <flameeyes>
Component: New packagesAssignee: Daniel Black (RETIRED) <dragonheart>
Status: RESOLVED FIXED    
Severity: QA CC: c1pher, crypto+disabled, hwoarang
Priority: High    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 331933    
Attachments: Build log
Ebuild diff from main tree
New makefile patch
Full ebuild
Updated makefile patch

Description Diego Elio Pettenò (RETIRED) gentoo-dev 2010-08-09 16:44:59 UTC
See attached build log.

(Please do not complain about the need for looking at the build log until you can provide an easy way to open bugs with the correct data picked out of a tinderbox log. Thanks.)
Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev 2010-08-09 16:45:19 UTC
Created attachment 242085 [details]
Build log
Comment 2 Dane Smith (RETIRED) gentoo-dev 2010-08-09 19:39:35 UTC
I will work on this as time permits.
Comment 3 Dane Smith (RETIRED) gentoo-dev 2010-08-09 21:27:13 UTC
Created attachment 242147 [details]
Ebuild diff from main tree

Notes:
${FILESDIR}/${P}-asneeded.patch is no longer necessary.

I will also be attaching a new ${FILESDIR}/${P}-makefile.patch. This replaces the one currently in the tree. It will address the lack of respect for LDFLAGS (And will also take care of what the old ${FILESDIR}/${P}-asneeded.patch did).

Hope this helps.
Comment 4 Dane Smith (RETIRED) gentoo-dev 2010-08-09 21:27:51 UTC
Created attachment 242149 [details]
New makefile patch
Comment 5 Dane Smith (RETIRED) gentoo-dev 2010-08-09 21:28:23 UTC
Created attachment 242151 [details]
Full ebuild

Just in case anyone wants it.
Comment 6 Samuli Suominen gentoo-dev 2010-08-11 03:32:37 UTC
Comment on attachment 242149 [details]
New makefile patch

The patch is wrong. Libraries come before objects to the linker line.

<compiler> <*flags> <objects> <libs>
Comment 7 Samuli Suominen gentoo-dev 2010-08-11 03:33:33 UTC
(In reply to comment #6)
> (From update of attachment 242149 [details])
> The patch is wrong. Libraries come before objects to the linker line.

That should read: Libraries come after objects to the linker line. :-) sorry about that.

> 
> <compiler> <*flags> <objects> <libs>
> 

Comment 8 Dane Smith (RETIRED) gentoo-dev 2010-08-11 04:35:03 UTC
Created attachment 242371 [details]
Updated makefile patch

Correct makefile.patch. Thanks for the catch =)
Comment 9 Dane Smith (RETIRED) gentoo-dev 2010-10-13 14:24:11 UTC
13 Oct 2010; Dane Smith <c1pher@gentoo.org> +rainbowcrack-1.2-r2.ebuild,
  +files/rainbowcrack-1.2-makefile-asneeded.patch:
  Revision bump for rainbowcrack. Addresses lack of LDFLAGS respect wrt bug
  #331877.

Fixed in -r2.