Bug 331813

Summary:	app-shells/scsh does not respect LDFLAGS
Product:	Gentoo Linux	Reporter:	Diego Elio Pettenò (RETIRED) <flameeyes>
Component:	New packages	Assignee:	Scheme Project <scheme>
Status:	RESOLVED FIXED
Severity:	QA	CC:	cyprien
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	331933
Attachments:	Build log Global patch for the repo

Description Diego Elio Pettenò (RETIRED) gentoo-dev

2010-08-09 16:24:56 UTC

See attached build log.

(Please do not complain about the need for looking at the build log until you can provide an easy way to open bugs with the correct data picked out of a tinderbox log. Thanks.)

Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev

2010-08-09 16:25:45 UTC

Created attachment 242025 [details]
Build log

Comment 2 Cyprien Nicolas (fulax) 2010-08-11 15:18:41 UTC

Created attachment 242431 [details, diff]
Global patch for the repo

This patches add LDFLAGS while building the scsh binary, and fix two includes missing in the C sources.

BTW, I don't get the QA notice about non respected LDFLAGS, so I *think* this should fix the issue.

If one want separated attachments for the new ebuild and the patches, let me know.

Comment 3 Markos Chandras (RETIRED) gentoo-dev

2010-08-12 14:24:48 UTC

+*scsh-0.6.7-r1 (12 Aug 2010)
+
+  12 Aug 2010; Markos Chandras <hwoarang@gentoo.org>
+  +files/0.6.7-Makefile.in-LDFLAGS.patch, +scsh-0.6.7-r1.ebuild,
+  +files/0.6.7-Missing-includes.patch:
+  Respect LDFLAGS. Add missing includes. Bug #331813. Thanks to Cyprien
+  Nicolas <c.nicolas+bugs@gmail.com> for the patch
+