Bug 331743

Summary:	x11-libs/cairo-1.9.12 + Cleartype patch
Product:	Gentoo Linux	Reporter:	Shlomi Steinberg <ssteinberg>
Component:	Current packages	Assignee:	Doug Goldstein (RETIRED) <cardoe>
Status:	RESOLVED FIXED
Severity:	enhancement	CC:	egorov_egor, electricityispower, gef.kornflakes, ghepeu, jackdachef, laurento.frittella, netcelli, spatz, steffen.weber, x11
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	cairo 1.9.12 ebuild cleartype patch

Description Shlomi Steinberg 2010-08-09 10:05:50 UTC

Currently there is a patch for 1.8.10 version, but none for 1.9.12. Here is a modified patch for 1.9.12 as well as the current live git build. The 1.9.12 ebuild is from the gnome overlay, add cleartype use flag.

Comment 1 Shlomi Steinberg 2010-08-09 10:06:35 UTC

Created attachment 241937 [details]
cairo 1.9.12 ebuild

Comment 2 Shlomi Steinberg 2010-08-09 10:07:01 UTC

Created attachment 241939 [details, diff]
cleartype patch

Comment 3 Denis Dupeyron (RETIRED) gentoo-dev

2010-09-09 14:34:30 UTC

Tested against cairo-1.10.0 and works great. Please add it to the new ebuild.

Denis.

Comment 4 Shlomi Steinberg 2010-09-09 14:38:54 UTC

Yeah, no modifications needed for 1.10.

Comment 5 Matt 2010-09-09 16:39:08 UTC

yeah, that patch applies cleanly to 1.10.0 

thanks !

Comment 6 Mark R. Pariente 2010-09-16 08:01:24 UTC

Patch applies cleanly to cairo-1.10.0-r3, please add to the ebuild.

Comment 7 Giacomo Perale 2010-09-18 13:33:21 UTC

This patch is useless, it just duplicates in cairo the functionality provided by freetype.

To enable cleartype-like filtering again you need the fontconfig patches you can find in bug 306053 and then you have to run 

eselect fontconfig enable 11-lcdfilter-default.conf

Comment 8 Andrzej Rybczak 2010-09-18 15:32:11 UTC

(In reply to comment #7)
> This patch is useless, it just duplicates in cairo the functionality provided
> by freetype.
Not really. I just tested you patch for fontconfig and there is slight difference between rendering using setting from fontconfig and provided by cairo-9999-cleartype.patch (I prefer the latter).

Comment 9 Shlomi Steinberg 2010-09-18 15:53:52 UTC

Actually I did miss that Cairo 1.10 uses freetype's filtering again. Those who prefer the fonts with this patch can apply it manually through local overlay, but there is no reason to merge upstream.

Comment 10 Giacomo Perale 2010-09-18 18:06:30 UTC

(In reply to comment #8)
> (In reply to comment #7)
> > This patch is useless, it just duplicates in cairo the functionality provided
> > by freetype.
> Not really. I just tested you patch for fontconfig and there is slight
> difference between rendering using setting from fontconfig and provided by
> cairo-9999-cleartype.patch (I prefer the latter).
> 

That's because the old cleartype patch (as this one does) used the coefficients 0x1C, 0x38, 0x55, 0x38, 0x1C while freetype uses 0x10, 0x40, 0x70, 0x40, 0x10.

Patch freetype with freetype-2.3.12-gentoo-lcdfilter.patch from the same bug 306053