| Summary: | net-libs/opal-3.6.7 doesn't respect LDFLAGS (patch provided) | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Olivier Huber <oli.huber> |
| Component: | Current packages | Assignee: | Mounir Lamouri (volkmar) (RETIRED) <volkmar> |
| Status: | RESOLVED FIXED | ||
| Severity: | QA | CC: | hwoarang, voip+disabled |
| Priority: | High | Keywords: | Inclusion |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 331933 | ||
| Attachments: |
patch
patch patch |
||
Created attachment 241285 [details, diff]
patch
I'm pretty sure there are more Makefile.in to fix in plugins/audio/ and plugins/video/, but I don't have all the USE flags enabled
Thanks for the patch. If you find time please provide a complete patch so we can fix it asap otherwise this bug will have to wait. Thanks :) Created attachment 241833 [details, diff]
patch
With this new patch, LDFLAGS are always respected. I've tested it with:
USE="audio capi celt doc dtmf examples fax ffmpeg h224 h281 h323 iax ipv6 ivr ixj java ldap lid plugins sbc sip sipim srtp ssl stats swig theora video vpb vxml wav x264 xml"
and USE="audio capi celt debug doc dtmf examples fax ffmpeg h224 h281 h323 iax ipv6 ivr ixj java ldap lid plugins sbc sip sipim srtp ssl stats swig theora video vpb vxml wav x264 xml".
Created attachment 241835 [details, diff]
patch
When I ran "grep '$(Q_LD)' -r . | grep -v LDFLAGS" in $S, I saw that there's one Makefile where LDFLAGS are ignored (in plugins/fax/fax_spandsp/). But it seems that no executable from this directory are installed, even when I enabled all the USE flags. I don't know whether this patch should be in the tree or not.
The patches are working with the new net-libs/opal-3.6.8 and they are still needed. Thank you Oliver. Fixed in 3.6.8-r1. |
from build.log: QA Notice: Files built without respecting LDFLAGS have been detected Please include the following list of files in your report: /usr/lib64/opal-3.6.7/codecs/audio/g722_audio_pwplugin.so /usr/lib64/opal-3.6.7/codecs/audio/ima_adpcm_audio_pwplugin.so /usr/lib64/opal-3.6.7/codecs/audio/g726_audio_pwplugin.so /usr/lib64/opal-3.6.7/codecs/audio/gsmamrcodec_pwplugin.so /usr/lib64/opal-3.6.7/codecs/audio/speex_audio_pwplugin.so /usr/lib64/opal-3.6.7/codecs/audio/gsm0610_audio_pwplugin.so /usr/lib64/opal-3.6.7/codecs/audio/lpc10_audio_pwplugin.so /usr/lib64/opal-3.6.7/codecs/audio/ilbc_audio_pwplugin.so /usr/lib64/opal-3.6.7/codecs/video/mpeg4-ffmpeg_video_pwplugin.so /usr/lib64/opal-3.6.7/codecs/video/h261-vic_video_pwplugin.so emerge --info net-libs/opal Portage 2.2_rc67 (default/linux/amd64/10.0/developer, gcc-4.5.0, glibc-2.11.2-r0, 2.6.35-gentoo x86_64) ================================================================= System Settings ================================================================= System uname: Linux-2.6.35-gentoo-x86_64-Intel-R-_Core-TM-2_Duo_CPU_P8600_@_2.40GHz-with-gentoo-2.0.1 Timestamp of tree: Mon, 02 Aug 2010 19:45:01 +0000 distcc[21694] (dcc_trace_version) distcc 3.1 x86_64-pc-linux-gnu; built Jun 8 2010 05:13:44 [disabled] ccache version 2.4 [enabled] app-shells/bash: 4.1_p7 dev-java/java-config: 2.1.11 dev-lang/python: 2.6.5-r3, 3.1.2-r4 dev-util/ccache: 2.4-r8 dev-util/cmake: 2.8.1-r2 sys-apps/baselayout: 2.0.1 sys-apps/openrc: 0.6.1-r1 sys-apps/sandbox: 2.2 sys-devel/autoconf: 2.13, 2.65-r1 sys-devel/automake: 1.4_p6-r1, 1.7.9-r2, 1.8.5-r4, 1.9.6-r3, 1.10.3, 1.11.1 sys-devel/binutils: 2.20.1-r1 sys-devel/gcc: 4.5.0 sys-devel/gcc-config: 1.4.1 sys-devel/libtool: 2.2.10 virtual/os-headers: 2.6.34 ACCEPT_KEYWORDS="amd64 ~amd64" ACCEPT_LICENSE="*" CBUILD="x86_64-pc-linux-gnu" CFLAGS="-march=core2 -O2 -pipe -g -mssse3 -msse4.1" CHOST="x86_64-pc-linux-gnu" CONFIG_PROTECT="/etc /usr/share/X11/xkb /usr/share/config /var/lib/hsqldb" CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/env.d/java/ /etc/eselect/postgresql /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/php/apache2-php5/ext-active/ /etc/php/cgi-php5/ext-active/ /etc/php/cli-php5/ext-active/ /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c" CXXFLAGS="-march=core2 -O2 -pipe -g -mssse3 -msse4.1" DISTDIR="/usr/portage/distfiles" FEATURES="assume-digests ccache collision-protect distlocks fixpackages multilib-strict news parallel-fetch preserve-libs protect-owned sandbox sfperms sign splitdebug strict test test-fail-continue unmerge-logs unmerge-orphans userfetch usersandbox" GENTOO_MIRRORS="http://lug.mtu.edu/gentoo/ http://mirror.ovh.net/gentoo-distfiles/" LANG="fr_FR.utf-8" LC_ALL="fr_FR.utf-8" LDFLAGS="-Wl,-O1 -Wl,--as-needed -Wl,--hash-style=gnu -Wl,--sort-common" LINGUAS="fr" MAKEOPTS="-j3" PKGDIR="/usr/portage/packages" PORTAGE_CONFIGROOT="/" PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages" PORTAGE_TMPDIR="/var/tmp" PORTDIR="/usr/portage" PORTDIR_OVERLAY="/usr/local/overlays/kde /usr/local/overlays/sci /usr/local/overlays/x11 /usr/local/overlays/embedded-cross /usr/local/overlays/local" SYNC="rsync://rsync.us.gentoo.org/gentoo-portage" USE="X a52 aac abook acl acpi adns alsa amd64 amr amrnb amrwb ares aspell ass bash-completion berkdb bluetooth bzip2 cairo caps cblas cdaudio cdda cddb cdio cdparanoia cdr cli consolekit cracklib crypt ctypes-python cups curl custom-cxxflags cvs cxx daap dbus detex device-mapper dia dirac djvu dns dri dts dv dvb dvd dvdnav dvdr dvipdfm emboss encode exif expat extensions extra faac faad fam fbcondecor ffmpeg fftw firefox flac fontconfig fontforge fortran frei0r ft2232 ftd2xx ftdi ftp fts3 fuse gallium gcrypt gd gdbm geoip gif glitz gmp gnutls gpg gpgme gpm graphics graphite graphviz gs gsm gstreamer gtk hal hdri humanities iconv icu id3tag idn imagemagick imap iproute2 ipv6 jack jadetex jingle jpeg jpeg2k kde kerberos kpathsea kqemu kvm lame lapack laptop lash latex latex3 lcms ldap libass libftdi libgcrypt libnotify libproxy libsamplerate libusb-0 libv4l libv4l2 live llvm-gcc lto lua lvm lzma lzo mad matroska mbox melt messenger mikmod mjpeg mktemp mmx mng modplug modules mp3 mp4 mpeg mplayer msn mtp mudflap multilib musepack music mysql ncurses nemesi nls nptl nptlonly nsplugin nss ntp ocaml ocamlopt octave ogg omega openexr opengl openmp openntpd openssl otr pam pango parport parport-giveio passwdqc pch pcre pda pdf perl phonon pipechan pkcs11 plotutils png pop postgres postproc postscript ppds pppd presto projectm pstricks publishers pulseaudio python qalculate qemu qt3support qt4 quicktime qwt rar readline reflection rnca rss rtmp rtsp ruby sasl schroedinger science sdl sdl-image secure-delete semantic-desktop sensord session shout sidebar sip smi smime sms smtp sndfile snmp speex spell spl sqlite sqlite3 sse sse2 sse3 ssh ssl ssse3 startup-notification stream strong-optimization subversion svg sysfs syslog system-sqlite t1lib taglib tcpd teletext tga theora threads thumbnail tiff tokyocabinet tools truetype udev udev-acl unicode upnp usb utils v4l v4l2 vaapi vcd vcdinfo vcdx vim-syntax virtualbox vorbis vpx wav wavpack webdav webkit wifi winpopup wmf x264 xcb xcomposite xine xml xorg xosd xulrunner xv xvid xvmc zlib zvbi" ALSA_CARDS="hda-intel" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" ELIBC="glibc" INPUT_DEVICES="keyboard mouse evdev synaptics" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LINGUAS="fr" RUBY_TARGETS="ruby18" USERLAND="GNU" VIDEO_CARDS="vesa intel v4l fbdev" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account" Unset: CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, FFLAGS, INSTALL_MASK, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS ================================================================= Package Settings ================================================================= net-libs/opal-3.6.7 was built with the following: USE="audio ffmpeg ipv6 ldap (multilib) plugins sip ssl test theora video wav x264 xml -capi -celt -debug -doc -dtmf -examples -fax -h224 -h281 -h323 -iax -ivr -ixj -java -lid -sbc -sipim -srtp -stats -swig -vpb -vxml -x264-static" CFLAGS="-march=core2 -O2 -pipe -g -mssse3 -msse4.1 -fno-visibility-inlines-hidden -D__STDC_CONSTANT_MACROS" CXXFLAGS="-march=core2 -O2 -pipe -g -mssse3 -msse4.1 -fno-visibility-inlines-hidden -D__STDC_CONSTANT_MACROS"