Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 33010

Summary: hardened-gcc fails to compile lilo-22.5.8-r1 due to missing -yet_exec
Product: Gentoo Linux Reporter: Radoslaw Szkodzinski <astralstorm>
Component: [OLD] Core systemAssignee: Alexander Gabert (RETIRED) <pappy>
Status: VERIFIED TEST-REQUEST    
Severity: major    
Priority: Highest    
Version: unspecified   
Hardware: x86   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: patch for ET_EXEC
REAL patch for the bug

Description Radoslaw Szkodzinski 2003-11-08 07:52:10 UTC
This ebuild doesn't have that option (unlike 22.5.8)
and it breaks with assembler error reported in bug 22758
Comment 1 Radoslaw Szkodzinski 2003-11-10 00:17:14 UTC
bah, my mistake: the error was first reported in bug 27758
Comment 2 Alexander Gabert (RETIRED) gentoo-dev 2003-11-11 01:11:38 UTC
okay, can we close it now?
Comment 3 Radoslaw Szkodzinski 2003-11-11 08:13:24 UTC
Created attachment 20596 [details, diff]
patch for ET_EXEC

As it is still unfixed, here's the patch.
Comment 4 Radoslaw Szkodzinski 2003-11-11 08:31:14 UTC
Comment on attachment 20596 [details, diff]
patch for ET_EXEC

I always feel bad when I attach the wrong file. :(
Comment 5 Radoslaw Szkodzinski 2003-11-11 08:38:15 UTC
Created attachment 20598 [details, diff]
REAL patch for the bug

There are no ${CFLAGS} on the line.
Comment 6 Alexander Gabert (RETIRED) gentoo-dev 2003-11-12 03:15:16 UTC
jo

alright, added my two cents to the ebuild:

src_compile() {
    # add the hardened-gcc compiler flag for building its assembler parts ;-)
    if has_version 'sys-devel/hardened-gcc'
    then
        export CC="${CC:=gcc} -yet_exec"
        find ${W} -type f -name "Makefile" -exec sed -i "s:CC=cc:CC=${CC}:" {} \;
    fi

    # Do not use custom CFLAGS for stability reasons
    emake CC="${CC:=gcc}" lilo || die

from the debug session:
+ src_compile
+ has_version sys-devel/hardened-gcc
+ /usr/lib/portage/bin/portageq has_version / sys-devel/hardened-gcc
+ return 0
+ export 'CC=gcc -yet_exec'
+ CC=gcc -yet_exec
+ find -type f -name Makefile -exec sed -i 's:CC=cc:CC=gcc -yet_exec:' '{}' ';'
+ emake 'CC=gcc -yet_exec' lilo

and it emerges here on my side :-)
Comment 7 Alexander Gabert (RETIRED) gentoo-dev 2003-11-12 03:16:05 UTC
please test with the snippet of the bug track or wait for cvs to hurry up syncing it to your machina

thanks,

Alex
Comment 8 Radoslaw Szkodzinski 2003-11-12 08:22:49 UTC
Works fine now.
Comment 9 Radoslaw Szkodzinski 2003-11-12 08:24:55 UTC
Heh, closing. Thank you for your work.