Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 329899

Summary: gnome-extra/nm-applet-0.7.2 should DEPEND on gnome-extra/polkit-gnome, not gnome-extra/policykit-gnome?
Product: Gentoo Linux Reporter: Sophie Tatch <tatch.m>
Component: New packagesAssignee: Robert Piasek (RETIRED) <dagger>
Status: RESOLVED INVALID    
Severity: normal CC: nirbheek, steev
Priority: High    
Version: unspecified   
Hardware: x86   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---

Description Sophie Tatch 2010-07-26 11:20:25 UTC
Hi, I'm kinda new in this, but I think I spotted, and fixed a problem in the NM-Applet e-build...


RDEPEND=">=dev-libs/glib-2.16
   >=dev-libs/dbus-glib-0.74
   >=sys-apps/dbus-1.2
   >=x11-libs/gtk+-2.14
   >=gnome-base/gconf-2.20
   >=gnome-extra/polkit-gnome-0.92
   >=x11-libs/libnotify-0.4.3
   >=gnome-base/libglade-2
   >=gnome-base/gnome-keyring-2.20

        >= gnome-extra/polkit-gnome-0.96

   >=dev-libs/libnl-1.1
   >=net-misc/networkmanager-${PV}
   >=net-wireless/wireless-tools-28_pre9
   >=net-wireless/wpa_supplicant-0.5.7
   || ( >=gnome-base/gnome-panel-2 xfce-base/xfce4-panel x11-misc/trayer )
   net-misc/mobile-broadband-provider-info
   bluetooth? ( >=net-wireless/gnome-bluetooth-2.27.6 )" 

Would have fixed to problem I think, and when that doesn't do the trick....

 DEPEND="${RDEPEND}
   dev-util/pkgconfig

        gnome-extra/polkit-gnome

   >=dev-util/intltool-0.35"


Would probably do the trick...

Greets from Me!

Reproducible: Always

Steps to Reproduce:
1. emerge nm-applet
2. wait a bit...
3. see what happens... ;)

Actual Results:  
E-build failed....

Expected Results:  
Someone takes a look, and sees that the above fixed the problem

I don't think emerge --info is a nescessity in this...

(Forgive me for not taking the advanced english course...)
Comment 1 Jeroen Roovers (RETIRED) gentoo-dev 2010-07-26 11:48:31 UTC
Could you please explain two things:

1) What the actual problem is (failing build log?).
2) What your solution is (I don't see an explanation of what you propose to change, just a DEPEND and RDEPEND list).
Comment 2 Sophie Tatch 2010-07-26 12:31:36 UTC
I don't have the failing build log anymore... 

What happened is that the emerge of nm-applet failed to build and after I installed polkit-gnome it did emerge... So accidently I checked the ebuild, and saw that there wasn't a entry for the gnome-polkit...

So I figured, with the RDEPEND, or DEPEND entry of polkit-gnome it would work...
Comment 3 Jeroen Roovers (RETIRED) gentoo-dev 2010-07-26 21:21:32 UTC
Thanks for the clarification. That we can put to the maintainers.
Comment 4 Nirbheek Chauhan (RETIRED) gentoo-dev 2010-07-26 22:02:09 UTC
nm-applet-0.7.2 uses policykit. Polkit is the rewrite of policykit, and nm-applet cannot possible use it since it was written before polkit was released.
Comment 5 Sophie Tatch 2010-07-27 07:42:37 UTC
When I emerged it, polkit-gnome, it emerged just fine...

Sophie
Comment 6 Nirbheek Chauhan (RETIRED) gentoo-dev 2010-07-28 16:06:34 UTC
(In reply to comment #5)
> When I emerged it, polkit-gnome, it emerged just fine...
> 

I just re-checked configure.ac, and it says the following:

-----
#### PolicyKit checks; need at least 0.6 or later
PKG_CHECK_EXISTS(polkit-gnome,[have_polkit_gnome=yes],[have_polkit_gnome=no])
if test x"$have_polkit_gnome" = "xyes"; then
        PKG_CHECK_MODULES(POLKIT, polkit-gnome)
else
        PKG_CHECK_MODULES(POLKIT, [polkit >= 0.6])
        PKG_CHECK_MODULES(POLKIT_DBUS, [polkit-dbus >= 0.6])
        AC_DEFINE([NO_POLKIT_GNOME],[1],[Define if you don't have PolicyKit-gnome 0.7 or later])
fi
AM_CONDITIONAL(NO_POLKIT_GNOME, test x"$have_polkit_gnome" = "xno")
-----

Please note this snippet checks for "polkit-gnome.pc" (a pkgconfig file):

        PKG_CHECK_MODULES(POLKIT, polkit-gnome)

This is provided by gnome-extra/policykit-gnome:

# q files -e policykit-gnome | grep polkit-gnome.pc
/usr/lib/pkgconfig/polkit-gnome.pc
#

*Not* gnome-extra/polkit-gnome:

# q files -e polkit-gnome | grep polkit-gnome.pc
#

----

Yes, the names are confusing (blame upstream for that), but configure.ac clearly says that it needs gnome-extra/policykit-gnome, not gnome-extra/polkit-gnome.

Please understand that we can't make a change unless we understand *why* that change is required. Without a build.log, I cannot diagnose your nm-applet build failure and find out exactly *how* adding polkit-gnome to the RDEPEND list fixed the build failure.

Thank you for filing the bug report, but unless you can reproduce the failure and past a build.log, my hands are tied.

Also, if you're confused about the differences between policykit and polkit, please see http://dev.gentoo.org/~nirbheek/polkit/naming.html