Bug 329747

Summary:	media-sound/mp3gain-1.5.2 version bump
Product:	Gentoo Linux	Reporter:	Zsolt Branyiczky <brazso>
Component:	New packages	Assignee:	Gentoo Linux bug wranglers <bug-wranglers>
Status:	RESOLVED FIXED
Severity:	enhancement
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
URL:	http://mp3gain.sourceforge.net/download.php
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	331211
Attachments:	ebuild for the new mp3gain 1.5.2 version diff from old to new ebuild

Description Zsolt Branyiczky 2010-07-24 20:49:07 UTC

There is a new version of mp3gain, which supports a new GUI named qmp3gain.
The old ebuild (1.5.1) was only slightly modified, the "format string vulnerability patch" is already not necessary, because the actual mp3gain source contains that.


Reproducible: Always

Steps to Reproduce:

Comment 1 Zsolt Branyiczky 2010-07-24 20:51:13 UTC

Created attachment 240045 [details]
ebuild for the new mp3gain 1.5.2 version

Comment 2 Zsolt Branyiczky 2010-07-24 20:51:48 UTC

Created attachment 240047 [details, diff]
diff from old to new ebuild

Comment 3 Samuli Suominen (RETIRED) gentoo-dev

2010-07-25 09:09:36 UTC

in tree

Comment 4 Zsolt Branyiczky 2010-07-30 09:28:44 UTC

(In reply to comment #3)
> in tree
> 
Thanks for your quick reaction! I could emerge the package successfully from the official portage (!) tree but I have found a strange thing when I run "make install" on the same mp3gain 1.5.2 source in Kubuntu 10.04 (gcc version 4.4.3).

My Makefile has the following install part:

install:
ifneq ($(OSTYPE),win)
	cp -p mp3gain$(EXE_EXT) "$(INSTALL_PATH)"
	ifeq ($(OSTYPE),beos)
		mimeset -f "$(INSTALL_PATH)/mp3gain$(EXE_EXT)"
	endif
else
	@echo install target is not implemented on windows
endif

And running the make install on Kubuntu:

brazso@brazso-desktop:~/work/mp3gain/mp3gain$ sudo make install
cp -p mp3gain "/usr/local/bin"
ifeq (,beos)
/bin/sh: Syntax error: word unexpected (expecting ")")
make: *** [install] Error 2

This problem was easily solved by removing the tab characters before ifeq/endif words. (Unfortunately I was unaware of the special meaning of the tab characters in the make files.) Do not ask me why this problem was not emerged on Gentoo, I do not know.

So I have to create a new version of mp3gain 1.5.2 where only the Makefile is changed inside. By choice I would not make a new official version for mp3gain, I would simple upload the new source-zipped file on the same (version) name defined by SRC_URI (mp3gain-1_5_2-src.zip). After the upload I think the emerge will not run because of the changed SRC_URI file content. Could you run a new "ebuild mp3gain-1.5.2.ebuild manifest" on the ebuild file after my upload?