Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 329661

Summary: x11-drivers/xf86-video-virtualbox - vboxvideo doesn't get automatically added to the moduledb for rebuildng via emerge @module-rebuild
Product: Gentoo Linux Reporter: Christopher Byrne <salah.coronya>
Component: [OLD] LibraryAssignee: Alessio Cassibba (X-Drum) <swapon>
Status: RESOLVED OBSOLETE    
Severity: normal CC: bkohler, frankol, polynomial-c, proxy-maint, uzytkownik2, zerochaos
Priority: High Keywords: PATCH
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: Explicity call linux-mod_pkg_postinst in pkg_postinst

Description Christopher Byrne 2010-07-24 04:40:37 UTC
vboxvideo isn't getting added asutomatically to the moduledb, however if "module-rebuild populate" is run, it does get added, but its a one-shot: It gets removed the next time its rebuilt.
Comment 1 Christopher Byrne 2010-08-08 02:51:20 UTC
Created attachment 241829 [details, diff]
Explicity call linux-mod_pkg_postinst in pkg_postinst

Found the problem. This package has its own pkg_postinst function which overrode the one in linux-mod.eclass. Calling linux-mod_pkg_postinst explicitly in pkg_postinst fixes the problem.
Comment 2 Faustus 2011-12-14 23:45:34 UTC
Any reason the ebuild is not fixed yet? I understand that it's very simple.
Comment 3 Mike Pagano gentoo-dev 2011-12-16 18:38:35 UTC
I think this is the right assignment. If not, please reassign as appropriate.
Comment 4 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2013-06-18 11:07:13 UTC
Is this still a problem? I've never used "module-rebuild" myself.
Comment 5 Ben Kohler gentoo-dev 2013-10-01 22:29:21 UTC
This is now handled via emerge @module-rebuild (for most people, that's portage-specific) but yes it's still a problem.  The call to linux-mod_pkg_postinst is the right idea, but it should probably be within the "if use dri" block in pkg_postinst, same as the linux-mod_* calls that are already in src_compile & src_install.
Comment 6 Tom Wijsman (TomWij) (RETIRED) gentoo-dev 2014-02-03 11:22:29 UTC
sys-kernel/module-rebuild has been treecleaned, see bug #410739 for reference.

Can you please close this bug as RESOLVED WONTFIX if is is only regarding the old module-rebuild and not reproducible with `emerge @module-rebuild`?
Comment 7 Ben Kohler gentoo-dev 2014-02-04 17:03:18 UTC
This is still a problem, and the fix is very simple.  Add a call to linux-mod_pkg_postinst within the "if use dri" block in pkg_postinst.
Comment 8 Rick Farina (Zero_Chaos) gentoo-dev 2014-02-04 21:07:06 UTC
(In reply to Ben Kohler from comment #7)
> This is still a problem, and the fix is very simple.  Add a call to
> linux-mod_pkg_postinst within the "if use dri" block in pkg_postinst.

patches welcome :-)
Comment 9 Ben Kohler gentoo-dev 2014-02-04 21:09:46 UTC
--- xf86-video-virtualbox-4.3.6.ebuild  2014-02-04 11:01:44.456505467 -0600
+++ xf86-video-virtualbox-4.3.6-r1.ebuild       2014-02-04 11:18:34.855199900 -0600
@@ -158,5 +158,6 @@
                        elog "/etc/modules.autoload.d/kernel-${KV_MAJOR}.${KV_MINOR}"
                fi
                elog ""
+               linux-mod_pkg_postinst
        fi
 }
Comment 10 Ben Kohler gentoo-dev 2014-03-05 13:51:21 UTC
I was wrong, this does not affect the @module-rebuild set.  Maybe it did at one time, or maybe I was wrong all along, not sure.