| Summary: | dev-vcs/git: Verify and potentially improve Python-related code | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Arfrever Frehtes Taifersar Arahesis (RETIRED) <arfrever> |
| Component: | Current packages | Assignee: | Robin Johnson <robbat2> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | ricmm |
| Priority: | High | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 308257 | ||
From build log of dev-vcs/git-1.7.2:
GEN git-svn
GEN git-remote-testgit
File "<string>", line 1
import sys; print 'lib/python%i.%i/site-packages' % sys.version_info[:2]
^
SyntaxError: invalid syntax
GEN git-instaweb
GEN git-mergetool--lib
I've gone with single-version of python2 support. Python3 support is a long way behind. Support multiple versions of python2 requires a large revamp of the build system, which I'm not undertaking at this time. The ebuilds should call python_mod_optimize() and python_mod_cleanup(). Example: use python && python_mod_optimize git_remote_helpers I have added calls to python_mod_optimize() and python_mod_cleanup(). Just a heads up. git has removed the python helper script since 1.8.5-rc0. https://github.com/git/git/commit/ae34ac126fa609fb17955b02c685d7de164b4e54 |
- If this package can be used as a library and installs Python modules (*.so or *.py) into site-packages directories, then consider supporting installation for multiple Python versions. Please read section "Types of packages" in documentation [1] to decide if this package can support installation for multiple Python versions. - Ensure that the ebuilds do not use deprecated functions or variables. - Please check if Python 3 is supported by this package. You can temporarily set Python 3 as main active version of Python to properly test if this package supports Python 3. - If this package does not support Python 3: - Specify dependency on Python 2. You can use PYTHON_DEPEND helper variable, which should be set before inheriting of python eclass. Please read section "Specification of dependency on Python" in documentation [1]. - If this package cannot support installation for multiple versions of Python, then set active version of Python using python_set_active_version(). - Ensure that shebangs in installed scripts specify correct version of Python. If shebangs are too generic (e.g. '#!/usr/bin/python'), then you can use python_convert_shebangs() to convert shebangs. (Wrapper scripts generated by python_generate_wrapper_scripts() do not require any changes.) Please read section "Shebangs in installed scripts" in documentation [1]. - To ensure that changes applied to the ebuilds are sufficient, please temporarily set Python 3 as main active version of Python and test if this package can be properly installed and if it works at run time. Please see documentation [1] for more details. [1] http://www.gentoo.org/proj/en/Python/developersguide.xml