Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 329479

Summary: dev-vcs/git: Verify and potentially improve Python-related code
Product: Gentoo Linux Reporter: Arfrever Frehtes Taifersar Arahesis (RETIRED) <arfrever>
Component: Current packagesAssignee: Robin Johnson <robbat2>
Severity: normal CC: ricmm
Priority: High    
Version: unspecified   
Hardware: All   
OS: All   
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 308257    

Description Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2010-07-22 21:20:23 UTC
- If this package can be used as a library and installs Python modules
  (*.so or *.py) into site-packages directories, then consider supporting
  installation for multiple Python versions.
  Please read section "Types of packages" in documentation [1] to decide
  if this package can support installation for multiple Python versions.

- Ensure that the ebuilds do not use deprecated functions or variables.

- Please check if Python 3 is supported by this package. You can temporarily
  set Python 3 as main active version of Python to properly test if this
  package supports Python 3.

- If this package does not support Python 3:
  - Specify dependency on Python 2.
    You can use PYTHON_DEPEND helper variable, which should be set before
    inheriting of python eclass.
    Please read section "Specification of dependency on Python" in
    documentation [1].

  - If this package cannot support installation for multiple versions of
    Python, then set active version of Python using

  - Ensure that shebangs in installed scripts specify correct version of
    Python. If shebangs are too generic (e.g. '#!/usr/bin/python'), then you
    can use python_convert_shebangs() to convert shebangs.
    (Wrapper scripts generated by python_generate_wrapper_scripts() do not
    require any changes.)
    Please read section "Shebangs in installed scripts" in documentation [1].

  - To ensure that changes applied to the ebuilds are sufficient, please
    temporarily set Python 3 as main active version of Python and test if
    this package can be properly installed and if it works at run time.

Please see documentation [1] for more details.
Comment 1 Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2010-07-22 21:22:45 UTC
From build log of dev-vcs/git-1.7.2:

    GEN git-svn
    GEN git-remote-testgit
  File "<string>", line 1
    import sys; print 'lib/python%i.%i/site-packages' % sys.version_info[:2]
SyntaxError: invalid syntax
    GEN git-instaweb
    GEN git-mergetool--lib
Comment 2 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2011-01-07 23:04:10 UTC
I've gone with single-version of python2 support. Python3 support is a long way behind.

Support multiple versions of python2 requires a large revamp of the build system, which I'm not undertaking at this time.
Comment 3 Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2011-01-08 14:18:23 UTC
The ebuilds should call python_mod_optimize() and python_mod_cleanup(). Example:
use python && python_mod_optimize git_remote_helpers
Comment 4 Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2011-01-10 18:44:25 UTC
I have added calls to python_mod_optimize() and python_mod_cleanup().
Comment 5 yegle 2013-10-31 01:43:04 UTC
Just a heads up. git has removed the python helper script since 1.8.5-rc0.