| Summary: | sys-apps/lcdtest segfaults when trying to initialize font | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Karl Hakimian <hyedad> |
| Component: | Current packages | Assignee: | Tony Vroon (RETIRED) <chainsaw> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | base-system, fellows, gavinlee303, kripton, nikoli |
| Priority: | High | ||
| Version: | unspecified | ||
| Hardware: | AMD64 | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
Patch to make help_font.c work with SDL.
lcdtest-1.18.ebuild lcdtest-1.18-SConscript.patch lcdtest-1.18-font-path.patch lcdtest-1.18.ebuild lcdtest-1.18.ebuild lcdtest-1.18.ebuild lcdtest-1.18.ebuild ported to eapi5 lcdtest-1.18.ebuild lcdtest-1.18.ebuild 1.18-build-system.patch |
||
|
Description
Karl Hakimian
2010-07-13 17:55:28 UTC
Looks like the problem start with loading the XPM file. I added a statement to print the error. IMG_ReadXPMFromArray: colour parse error Looks like the issue is help_font.c and SDL. SDL does not like the file. I loaded it in xv and re-saved it and things work fine. I will attach a patch that will make the new help_font.c file. Created attachment 238633 [details, diff]
Patch to make help_font.c work with SDL.
Digging in deeper, I see that this patch does not help since the xpm is built on the fly. Looks like netpbm is producing a file that SDL does not like. I re-emerge netpbm and that did not help. Still looking for a good fix. A file created by imagemagick instead of netpbm works fine. If having imagemagick as a dependency is not desirable, maybe producing a good file and simply copying it in is what should be done. I can confirm that segfault on x86 too. I came across this just now so I have bumped lcdtest to 1.18 in my overlay and converted the ebuild to use scons. It includes 2 patches, one for the SConscript file for obeying CC/LDFLAGS and another to find the correct path of LiberationMono-Regular.ttf. I'm not sure this is the correct thing to do but at least the package works for me now. I omitted the 1.08-help-option.patch as I'm not sure what that fixes, that may be needed too. Attached files follow. Thanks. Created attachment 245489 [details]
lcdtest-1.18.ebuild
Created attachment 245490 [details, diff]
lcdtest-1.18-SConscript.patch
Created attachment 245492 [details, diff]
lcdtest-1.18-font-path.patch
Created attachment 245496 [details]
lcdtest-1.18.ebuild
I forgot the media-libs/sdl-ttf dependency. Sorry for the noise.
Created attachment 245500 [details]
lcdtest-1.18.ebuild
edited dependencies again, I hope it's better this time...
Confirm that the proposed ebuild lcdtest-1.18 and two patches have resolved the segfault issue for me on x86_64. I can confirm a)that 1.08 segfaults on startup on amd64 and
b)the proposed 1.18 ebuild plus the two patches works as expected on amd64.
Thanks for the reports. I think the font path patch should maybe use sed instead, also the ebuild could make use of the scons eclass which it does not at the moment. A bit pressed for time right now as I'm about to go for surgery in a few hours, all going well I will take a look and clean it up when I get some time. Thanks again. Updated ebuild. Changes: bump to EAPI=2 as the sdl deps use it anyway remove font path patch and sed the source from inside the ebuild instead make use of scons-utils.eclass cleanup deps and ebuild according to EAPI change and the use of scons eclass Files follow, thanks. Created attachment 257320 [details]
lcdtest-1.18.ebuild
This package is now removed from portage, as per the e-mail sent to gentoo-dev. Unfortunately I was unable to solicit interest from other developers. Created attachment 345766 [details]
lcdtest-1.18.ebuild ported to eapi5
Reworked and ported to EAPI5, works fine here. Tool is useful, want to proxy maintain.
Thank you Nikoli. Could you "inherit base" and use "base_src_prepare" and the PATCHES variable instead of using epatch. I am happy to proxy this for you. Created attachment 345778 [details]
lcdtest-1.18.ebuild
Thank you. And can we follow this advice without ill effect? scons: warning: The build_dir keyword has been deprecated; use the variant_dir keyword instead. File "/var/tmp/portage/sys-apps/lcdtest-1.18/work/lcdtest-1.18/SConstruct", line 127, in <module> scons: warning: The build_dir keyword has been deprecated; use the variant_dir keyword instead. File "/var/tmp/portage/sys-apps/lcdtest-1.18/work/lcdtest-1.18/SConstruct", line 141, in <module> Created attachment 345780 [details]
lcdtest-1.18.ebuild
Created attachment 345782 [details, diff]
1.18-build-system.patch
+*lcdtest-1.18 (17 Apr 2013) + + 17 Apr 2013; Tony Vroon <chainsaw@gentoo.org> +files/1.18-build-system.patch, + +lcdtest-1.18.ebuild, +metadata.xml: + Reintroduction of a previously removed package. Ebuild by Gavin Pryke & + Nikoli; closes bug #328137. Many thanks to you both. Nikoli, as requested you are in metadata.xml as a proxy maintainer. Any further improvements should now be filed as new bugs please. Strange, after emerge --sync my portage tree does not have lcdtest: # emerge --info|grep Timestamp Timestamp of tree: Wed, 17 Apr 2013 19:15:01 +0000 But http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/sys-apps/lcdtest/ tells 'Wed Apr 17 13:41:48 2013 UTC' Any idea? Now after 'emerge --sync' my portage tree has lcdtest, still do not know why such delay happened. |
