Bug 327327

Summary:	www-servers/apache apache-2.eclass: make cgi cgid modules modular via apache2_modules USE flag
Product:	Gentoo Linux	Reporter:	Fabio Erculiani (RETIRED) <lxnay>
Component:	Eclasses	Assignee:	Apache Team - Bugzilla Reports <apache-bugs>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	309575
Attachments:	proposed eclass change make cgi cgid modules optional

Description Fabio Erculiani (RETIRED) gentoo-dev

2010-07-07 14:57:02 UTC

Beside it's a requirement in order to make 389 Directory Server ebuilds I'm working on fully happy. It would be good to always have both mod_cgi and mod_cgid built as shared object for every selected MPM. Beside upstream discourages the usage of mod_cgi with multithreaded MPMs, the former can be used without problems, and in fact, 389 Directory Server (http://port389.org) is using apache that way.

I think it would be a plus to let both modules be built as shared objects. Currently, when a multithreaded MPM is selected, mod_cgi is statically built, resulting in inability to disable/enable it via LoadModule directives (as upstream said).


Reproducible: Always

Comment 1 Fabio Erculiani (RETIRED) gentoo-dev

2010-07-07 14:58:00 UTC

Created attachment 237897 [details, diff]
proposed eclass change

This is the proposed apache-2.eclass change

Comment 2 Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev

2010-07-10 14:54:55 UTC

Maybe it would be better/easier to use apache2_modules_cgi and apache2_modules_cgid USE flags?

Comment 3 Fabio Erculiani (RETIRED) gentoo-dev

2010-07-10 15:01:24 UTC

...or move cgi/cgid modules compilation to apache2_modules_ use flags.

Comment 4 Fabio Erculiani (RETIRED) gentoo-dev

2010-07-10 15:10:22 UTC

Yes, if you ack I can do it very quickly.

Comment 5 Fabio Erculiani (RETIRED) gentoo-dev

2010-07-10 15:50:55 UTC

Created attachment 238223 [details, diff]
make cgi cgid modules optional

Here is the proposed patch, apache-2.2.15.ebuild should be revbumped and perhaps changes ported to 2.2.14 ebuild too. Let me know.

Comment 6 Benedikt Böhm (RETIRED) gentoo-dev

2010-07-10 20:18:42 UTC

looks good, please feel free to fix it in cvs. with the upcoming multi-mpm support in apache 2.3 this makes much more sense too.

Comment 7 Fabio Erculiani (RETIRED) gentoo-dev

2010-07-11 08:49:38 UTC

In CVS. Please review my changes anyway.