Summary: | x11-misc/xkeyboard-config depends on sys-devel/gettext | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Aelia <diego.abelenda> |
Component: | New packages | Assignee: | Gentoo X packagers <x11> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | ssuominen |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- |
Description
Aelia
2010-07-03 19:21:09 UTC
there's also bug 314953... not sure if we should just add gettext to intltool's deps directly true, that might be better to add dependency directly to intltool it is the binary that needs gettext as stated by the configure script. I didn't realize intltool was in another ebuild when I saw the error message just thought it was an internal tool compiled by gettext. actually, even if bug 314953 is valid (and it seems to be), xkeyboard-config defines it's own gettext depend in configure.ac too: GETTEXT_PACKAGE=xkeyboard-config AC_SUBST(GETTEXT_PACKAGE) AC_DEFINE_UNQUOTED(GETTEXT_PACKAGE, "$GETTEXT_PACKAGE", [Gettext package]) so it should also depend on it I've been digging a lot in intltool lately and I think intltool should just depend on gettext since you can't use intltool without using gettext *directly*. The easiest thing we can do for ebuild writers is to make the gettext dep useless when depending on intltool. Cheers (In reply to comment #4) > I've been digging a lot in intltool lately and I think intltool should just > depend on gettext since you can't use intltool without using gettext > *directly*. > > The easiest thing we can do for ebuild writers is to make the gettext dep > useless when depending on intltool. > > Cheers > Then, there is no need to keep this bug open anymore, is there? I agree it should stay as one, but it's still implicit depend and they are error prone... "until someone decides intltool shouldn't depend on gettext anymore", really want to count on that? :) I'd prefer if the commit was just added for good example to others. @samuli, remi: so WHAT should we do, this is open long enough, lets just add that gettext to intltool and be done with it... Proposed fix as github pull request https://github.com/gentoo/gentoo/pull/3760 [master 49451837fc] x11-misc/xkeyboard-config: DEPEND on sys-devel/gettext Author: Harri Nieminen <moikkis@gmail.com> Date: Wed Feb 1 16:38:08 2017 +0200 6 files changed, 6 insertions(+) |