Bug 326103 – dev-util/metro: Verify and potentially improve Python-related code

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Arfrever Frehtes Taifersar Arahesis (RETIRED) 2010-06-29 07:03:45 UTC]

- If this package can be used as a library and installs Python modules
  (*.so or *.py) into site-packages directories, then consider supporting
  installation for multiple Python versions.
  Please read section "Types of packages" in documentation [1] to decide
  if this package can support installation for multiple Python versions.

- Ensure that the ebuilds do not use deprecated functions or variables.

- Please check if Python 3 is supported by this package. You can temporarily
  set Python 3 as main active version of Python to properly test if this
  package supports Python 3.

- If this package does not support Python 3:
  - Specify dependency on Python 2.
    You can use PYTHON_DEPEND helper variable, which should be set before
    inheriting of python eclass.
    Please read section "Specification of dependency on Python" in
    documentation [1].

  - If this package cannot support installation for multiple versions of
    Python, then set active version of Python using
    python_set_active_version().

  - Ensure that shebangs in installed scripts specify correct version of
    Python. If shebangs are too generic (e.g. '#!/usr/bin/python'), then you
    can use python_convert_shebangs() to convert shebangs.
    (Wrapper scripts generated by python_generate_wrapper_scripts() do not
    require any changes.)
    Please read section "Shebangs in installed scripts" in documentation [1].

  - To ensure that changes applied to the ebuilds are sufficient, please
    temporarily set Python 3 as main active version of Python and test if
    this package can be properly installed and if it works at run time.

Please see documentation [1] for more details.
[1] http://www.gentoo.org/proj/en/Python/developersguide.xml

[Comment 1 Ian Delaney (RETIRED) 2011-11-15 20:15:28 UTC]

Created attachment 292683 [details, diff]
ebuild patch

[Comment 2 Arfrever Frehtes Taifersar Arahesis 2011-11-16 19:22:23 UTC]

(In reply to comment #1)

PYTHON_DEPEND="2"

python_convert_shebangs() called on "${ED}" before installation of files into "${ED}" won't help.

[Comment 3 Ian Delaney (RETIRED) 2011-11-17 02:16:43 UTC]

Created attachment 292841 [details, diff]
revised ebuild patch

[Comment 4 Arfrever Frehtes Taifersar Arahesis 2011-11-18 01:34:13 UTC]

(In reply to comment #3)

This patch changes each ebuild twice.

Use PYTHON_DEPEND="2".

[Comment 5 Arfrever Frehtes Taifersar Arahesis 2011-11-18 01:35:10 UTC]

Please reassign this bug to [e-mail].

[Comment 6 Benedikt Böhm (RETIRED) 2011-11-20 07:05:44 UTC]

in cvs, thanks for the patch