Bug 325615

Summary:	x11-plugins/wmhdplop doesn't work on 64-bit
Product:	Gentoo Linux	Reporter:	Mikael Magnusson <mikachu>
Component:	New packages	Assignee:	Gentoo Dockapp Team <desktop-dock>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	fix

Description Mikael Magnusson 2010-06-25 21:54:46 UTC

#92519 isn't totally true, it actually doesn't work on 64-bit, after a while (80 days for me) the procstats fields will overflow the signed int field and the hd leds will be permanently on. the problem is using ints instead of longs.

Comment 1 Mikael Magnusson 2010-06-25 21:55:58 UTC

Created attachment 236565 [details, diff]
fix

some of the int->long may or may not be needed, but what the hey.

Comment 2 Bernard Cafarelli gentoo-dev

2010-06-29 09:50:11 UTC

Yes, probably the keywording team did not try running the dockapp for more than 80 days ;)

Thanks for the patch, I've added it in 0.9.9-r1

Comment 3 Mikael Magnusson 2010-06-29 15:52:29 UTC

fwiw the problem isn't fixed by restarting the dockapp, the issue is the numbers in /proc/diskstat no longer fit in a signed int, re the changelog entry. i'll let you know in a couple of million years if it needs to be unsigned long. :)