Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 324393

Summary: dev-util/flawfinder: Verify and potentially improve Python-related code
Product: Gentoo Linux Reporter: Arfrever Frehtes Taifersar Arahesis (RETIRED) <arfrever>
Component: Current packagesAssignee: No maintainer - Look at if you want to take care of it <maintainer-needed>
Severity: normal    
Priority: High    
Version: unspecified   
Hardware: All   
OS: All   
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 308257    
Attachments: flawfinder-1.27-r1.ebuild.diff
ebuild patch

Description Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2010-06-16 20:38:45 UTC
- If this package can be used as a library and installs Python modules
  (*.so or *.py) into site-packages directories, then consider supporting
  installation for multiple Python versions.
  Please read section "Types of packages" in documentation [1] to decide
  if this package can support installation for multiple Python versions.

- Ensure that the ebuilds do not use deprecated functions or variables.

- Please check if Python 3 is supported by this package. You can temporarily
  set Python 3 as main active version of Python to properly test if this
  package supports Python 3.

- If this package does not support Python 3:
  - Specify dependency on Python 2.
    You can use PYTHON_DEPEND helper variable, which should be set before
    inheriting of python eclass.
    Please read section "Specification of dependency on Python" in
    documentation [1].

  - If this package cannot support installation for multiple versions of
    Python, then set active version of Python using

  - Ensure that shebangs in installed scripts specify correct version of
    Python. If shebangs are too generic (e.g. '#!/usr/bin/python'), then you
    can use python_convert_shebangs() to convert shebangs.
    (Wrapper scripts generated by python_generate_wrapper_scripts() do not
    require any changes.)
    Please read section "Shebangs in installed scripts" in documentation [1].

  - To ensure that changes applied to the ebuilds are sufficient, please
    temporarily set Python 3 as main active version of Python and test if
    this package can be properly installed and if it works at run time.

Please see documentation [1] for more details.
Comment 1 David Abbott gentoo-dev 2010-06-18 22:58:38 UTC
Created attachment 235887 [details]

Installs with both 2.6 and 3.1 tested here.
Will not run with 3.1 because of old style print
Comment 2 Ian Delaney (RETIRED) gentoo-dev 2011-11-25 16:10:34 UTC
Created attachment 293727 [details, diff]
ebuild patch

turns out /usr/bin/flawfinder is a script, so in with the shebang fixer.
Comment 3 Mike Gilbert gentoo-dev 2011-11-26 01:38:59 UTC
+*flawfinder-1.27-r2 (26 Nov 2011)
+  26 Nov 2011; Mike Gilbert <> +flawfinder-1.27-r2.ebuild:
+  Python-related improvements by Ian Delaney. Bug 324393.