Summary: | media-libs/jbig2dec fails tests | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Diego Elio Pettenò (RETIRED) <flameeyes> |
Component: | Current packages | Assignee: | Gentoo Graphics Project <graphics+disabled> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | pipping, printing |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 345159 | ||
Attachments: | Build log |
Description
Diego Elio Pettenò (RETIRED)
2010-06-16 11:59:19 UTC
Created attachment 235561 [details]
Build log
The files this test needs are missing from the tarball, and it'll always have return value of 1 (FAIL) because of it. Fun. $ ./test_jbig2dec.py ------------------------------------------------------------------------ ran 0 tests in 0.000 seconds PASSED all 0 tests $ echo $? 1 (In reply to comment #2) > The files this test needs are missing from the tarball, and it'll always have > return value of 1 (FAIL) because of it. Fun. > > $ ./test_jbig2dec.py > ------------------------------------------------------------------------ > ran 0 tests in 0.000 seconds > > PASSED all 0 tests > $ echo $? > 1 With this in mind, the test "failure" is not really something we can / have to worry about, and there is no reason to keep this bug open. Note added in the ebuild for documentation. Instead of all this fuzz: RESTRICT="test" #the test files are missing from the tarball, nothing is tested and the #test function just returns error. permanently restricted, see bug 324275 This should have gone in instead: src_test() { :; } #324275 So it stops showing up in Diego's scannings (he requested it previously in another bug, and I think it's a good way to separate the workarounds from cases like this) The necessary files are available from here: http://jbig2dec.sourceforge.net/ubc/main.html the test results don't look very good, though. not really CANTFIX if the testsuite is downloadable from net and we have the possibility of tarballing & fixing the suite Here's what I did in Exherbo to deal with the problem: * download the test suite and move it to ../ucb: http://git.exherbo.org/?p=arbor.git;a=commitdiff;h=17265727d80dba91f206e75cf87a75483f8abcb3 * disable tests that fail: http://git.exherbo.org/?p=arbor.git;a=commitdiff;h=6ea5e1e4c282fa01457ef97ac644945734e8ba32 * fix python runner (it would just return 1 even if all tests passed): http://git.exherbo.org/?p=arbor.git;a=commitdiff;h=471cf568f841228d4723408c4a384cb0b92b23b9 With 0.11, seven tests fail; with current git HEAD, six tests fail. I guess that's what's meant by "This is a decoder only implementation, and currently is in the alpha stage, meaning it doesn't completely work yet. However, we are maintaining parity with available encoders, so it is useful for real work." on jbig2dec's website[1]. ghostscript comes bundled with a version of jbig2dec that appears to carry fixes not even git HEAD of jbig2dec has; e.g. a fix for libpng-1.4-detection. No idea what's up with that. [1] http://jbig2dec.sourceforge.net/ Added testdata to SRC_URI, made it run... Still leaving it restricted though. make check-TESTS make[1]: Entering directory `/var/tmp/portage/media-libs/jbig2dec-0.11-r1/work/jbig2dec-0.11' verifying SHA-1 implementation... ok PASS: test_sha1 Checking '../ubc/042_1.jb2' for correct decoded document hash ... ok Checking '../ubc/042_2.jb2' for correct decoded document hash ... ok Checking '../ubc/042_3.jb2' for correct decoded document hash ... ok Checking '../ubc/042_4.jb2' for correct decoded document hash ... ok Checking '../ubc/042_5.jb2' for correct decoded document hash ... ok Checking '../ubc/042_6.jb2' for correct decoded document hash ... ok Checking '../ubc/042_7.jb2' for correct decoded document hash ... ok Checking '../ubc/042_8.jb2' for correct decoded document hash ... ok Checking '../ubc/042_9.jb2' for correct decoded document hash ... ok Checking '../ubc/042_10.jb2' for correct decoded document hash ... ok Checking '../ubc/042_11.jb2' for correct decoded document hash ... FAIL Checking '../ubc/042_12.jb2' for correct decoded document hash ... ok Checking '../ubc/042_13.jb2' for correct decoded document hash ... jbig2dec FATAL ERROR refinement references unknown symbol 578 (segment 0x03) FAIL Checking '../ubc/042_14.jb2' for correct decoded document hash ... FAIL Checking '../ubc/042_15.jb2' for correct decoded document hash ... ok Checking '../ubc/042_16.jb2' for correct decoded document hash ... ok Checking '../ubc/042_17.jb2' for correct decoded document hash ... ok Checking '../ubc/042_18.jb2' for correct decoded document hash ... ok Checking '../ubc/042_19.jb2' for correct decoded document hash ... ok Checking '../ubc/042_20.jb2' for correct decoded document hash ... ok Checking '../ubc/042_21.jb2' for correct decoded document hash ... ok Checking '../ubc/042_22.jb2' for correct decoded document hash ... ok Checking '../ubc/042_23.jb2' for correct decoded document hash ... ok Checking '../ubc/042_24.jb2' for correct decoded document hash ... FAIL Checking '../ubc/042_25.jb2' for correct decoded document hash ... FAIL Checking '../ubc/amb_1.jb2' for correct decoded document hash ... FAIL Checking '../ubc/amb_2.jb2' for correct decoded document hash ... FAIL ------------------------------------------------------------------------ ran 27 tests in 3.022 seconds FAILED 7 of 27 tests FAIL: test_jbig2dec.py testing jbig2 huffmann decoding... (should be 8 5 (oob) 8) 8 5 (oob) 8 PASS: test_huffman PASS: test_arith ========================================== 1 of 4 tests failed Please report to jbig2-dev@ghostscript.com ========================================== make[1]: *** [check-TESTS] Fehler 1 Still failing in 0.13 The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2a2d8d026d6ae11d8d3b48cce8b8e04cd174950e commit 2a2d8d026d6ae11d8d3b48cce8b8e04cd174950e Author: Thomas Deutschmann <whissi@gentoo.org> AuthorDate: 2019-10-06 23:58:29 +0000 Commit: Thomas Deutschmann <whissi@gentoo.org> CommitDate: 2019-10-07 00:35:22 +0000 media-libs/jbig2dec: bump to v0.17 Tests re-enabled. Closes: https://bugs.gentoo.org/324275 Package-Manager: Portage-2.3.76, Repoman-2.3.17 Signed-off-by: Thomas Deutschmann <whissi@gentoo.org> media-libs/jbig2dec/Manifest | 1 + .../files/jbig2dec-0.17-fix-test_jbig2dec.py.patch | 39 +++++++++++++ media-libs/jbig2dec/jbig2dec-0.17.ebuild | 67 ++++++++++++++++++++++ 3 files changed, 107 insertions(+) |