Bug 324195 – games-kids/gcompris: Verify and potentially improve Python-related code

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Arfrever Frehtes Taifersar Arahesis (RETIRED) 2010-06-16 01:10:22 UTC]

- If this package can be used as a library and installs Python modules
  (*.so or *.py) into site-packages directories, then consider supporting
  installation for multiple Python versions.
  Please read section "Types of packages" in documentation [1] to decide
  if this package can support installation for multiple Python versions.

- Ensure that the ebuilds do not use deprecated functions or variables.

- Please check if Python 3 is supported by this package. You can temporarily
  set Python 3 as main active version of Python to properly test if this
  package supports Python 3.

- If this package does not support Python 3:
  - Specify dependency on Python 2.
    You can use PYTHON_DEPEND helper variable, which should be set before
    inheriting of python eclass.
    Please read section "Specification of dependency on Python" in
    documentation [1].

  - If this package cannot support installation for multiple versions of
    Python, then set active version of Python using
    python_set_active_version().

  - Ensure that shebangs in installed scripts specify correct version of
    Python. If shebangs are too generic (e.g. '#!/usr/bin/python'), then you
    can use python_convert_shebangs() to convert shebangs.
    (Wrapper scripts generated by python_generate_wrapper_scripts() do not
    require any changes.)
    Please read section "Shebangs in installed scripts" in documentation [1].

  - To ensure that changes applied to the ebuilds are sufficient, please
    temporarily set Python 3 as main active version of Python and test if
    this package can be properly installed and if it works at run time.

Please see documentation [1] for more details.
[1] http://www.gentoo.org/proj/en/Python/developersguide.xml

[Comment 1 Arfrever Frehtes Taifersar Arahesis (RETIRED) 2010-06-16 01:16:45 UTC]

Created attachment 235497 [details, diff]
gcompris-8.4.12.ebuild.patch

This patch removes deprecation warning in games-kids/gcompris-8.4.12.

I will commit this patch, if you don't object in 1 week.

[Comment 2 Arfrever Frehtes Taifersar Arahesis (RETIRED) 2010-06-16 01:22:54 UTC]

Created attachment 235499 [details, diff]
gcompris-9.2.2.ebuild.patch

games-kids/gcompris-9.2.2 has optional dependency on Python, but python_set_active_version() will trigger call to die() when Python isn't installed.

games-kids/gcompris-9.2.2 sets PYTHON_USE_WITH variable, so it should also call python_pkg_setup().

This patch also simplifies src_configure().

[Comment 3 Arfrever Frehtes Taifersar Arahesis (RETIRED) 2010-06-16 02:10:55 UTC]

Fixed. (Commits approved by Mr_Bones_.)