Summary: | golly-2.1 (New Package) | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Maks Verver <maksverver> |
Component: | New packages | Assignee: | Michael Weber (RETIRED) <xmw> |
Status: | RESOLVED FIXED | ||
Severity: | enhancement | Keywords: | EBUILD |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://golly.sourceforge.net/ | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
The ebuild itself.
files/perl-ldopts.patch files/python-amd64.patch files/separate-data-directory.patch patch to compile against Perl with ithread/multiplicity support |
Description
Maks Verver
2010-06-08 17:13:57 UTC
Created attachment 234553 [details]
The ebuild itself.
Created attachment 234555 [details, diff]
files/perl-ldopts.patch
Created attachment 234557 [details, diff]
files/python-amd64.patch
This fixes an error in the source code that would prevent loading Python scripts on AMD64 because of symbol naming differences.
Created attachment 234559 [details]
files/separate-data-directory.patch
The default distribution assumes binaries and data files (help files, patterns, rules, scripts, et cetera) are installed in the same directory, but I want to install binaries into /usr/bin and data files into /usr/share/golly. This patch hardcodes the data directory.
For reference: I've tested compiling, running, saving/loading, Perl scripting and Python scripting on AMD64. Everything seems to work correctly. Hello Maks, would be nice to review it in #gentoo-sunrise on irc.freenode.net. Thanks, On behalf of the Gentoo Sunrise Team, Michael "not a sunrise member yet" Weber. [1]: http://www.gentoo.org/proj/en/sunrise/ [2]: http://overlays.gentoo.org/proj/sunrise/wiki/SunriseFaq It's now in the Sunrise overlay: https://overlays.gentoo.org/proj/sunrise/browser/reviewed/app-misc/golly Hi Maks, are You shure that perl[ithreads] is needed? Is there a problem without itdreads and how can i reproduce the error? I've just installed it on dev-lang/perl-5.8.8-r8 w/o ithreads and it runs. *wondering* Michael +*golly-2.1 (16 Sep 2010) + + 16 Sep 2010; Michael Weber <xmw@gentoo.org> +golly-2.1.ebuild, + +files/golly-2.1-as-needed.patch, +files/golly-2.1-perl-ldopts.patch, + +files/golly-2.1-python-amd64.patch, + +files/golly-separate-data-directory.patch, +metadata.xml: + Initial import from sunrise overlay. Thanks to Maks Verver + <maksverver@geocities.com> on bug #323219 for the ebuild and patches, + great work. + (In reply to comment #8) > Are you sure that perl[ithreads] is needed? [..] I've just installed it on > dev-lang/perl-5.8.8-r8 w/o ithreads and it runs. I only tested with perl 5.10 and 5.12 myself, but the source code doesn't compile with a non-threaded interpreter, because wxPerl.cpp depends on the type perl_key being defined, which is the return type for Perl_Gthr_key_ptr(). Take a look at perlvars.h to see this isn't defined without interpreter threads. It may well true that Golly runs fine without it, though. A lot of the functions in the Perl bindings are declared but not actually used, and since they are loaded dynamically, as long as the functions aren't actually called nothing breaks (which is probably why all the conditional declarations work). What I don't understand is why these functions are declared at all then. Since I don't fully understand the Perl bindings yet, I'll go ask the original author about it, because I don't fully understand how the Perl bindings work myself. In the mean time, if you want to discuss this in a more interactive manner, you can probably catch me on #gentoo-sunrise. :-) It turned out to be slightly more complicated than I'd anticipated, but I managed to update wxperl.cpp to allow compiling against a Perl library without ithreads/multiplicity support. The patch is attached, and is also added to CVS, so if there are no strange side-effects it will be incorporated in the next release. In the meantime, I'd suggest either adding the patch to the ebuild or adding the perl[ithreads] dependency back in. Created attachment 248405 [details, diff]
patch to compile against Perl with ithread/multiplicity support
(In reply to comment #12) > Created an attachment (id=248405) [details] > patch to compile against Perl with ithread/multiplicity support Except in the above I mean WITHOUT ithread/multiplicity support of course. Gaah! Ok, let's wait on the new golly release to make perl[ithreads] optional. |