Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 323191

Summary: [gnome-live] gnome-live eclass has little typo: IT_PROG_INTLTOOL instead of AT_PROG_INTLTOOL
Product: Gentoo Linux Reporter: Maxim Koltsov (RETIRED) <maksbotan>
Component: [OLD] GNOMEAssignee: Gentoo Linux Gnome Desktop Team <gnome>
Status: RESOLVED FIXED    
Severity: major Keywords: InOverlay
Priority: High    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---

Description Maxim Koltsov (RETIRED) gentoo-dev 2010-06-08 14:04:25 UTC
This is fragment fo=rom gnome-live.eclass:
if grep -qe "IT_PROG_INTLTOOL" configure.*; then
    intltoolize --force
fi
This must call intltoolize if package needs it. But due to typo (IT_PROG_INTLTOOL instead of AT_PROG_INTLTOOL) it doesnt. So some packages from gnome-live overlay doesnt compile(e.g. gtk-engines-murrine-9999, error is "config.status: error: cannot find input
file: `po/Makefile.in.in' ".
Please fix it.

Reproducible: Always

Steps to Reproduce:
1.layman -i gnome-live
2.unmask (for example) gtk-engines-murrine-9999
3.emerge gtk-engines-murrine

Actual Results:  
Error

Expected Results:  
Compilation
Comment 1 Gilles Dartiguelongue (RETIRED) gentoo-dev 2010-06-08 14:14:01 UTC
from intltool package, intltool.m4:
# deprecated macros
AU_ALIAS([AC_PROG_INTLTOOL], ...

IT_PROG_INTLTOOL is the way to go, make sure upstream is updated on the fact that they are using obsolete macro names.
Comment 2 Mart Raudsepp gentoo-dev 2010-06-08 14:18:04 UTC
We should support both ways in the eclass regardless.

if grep -qe "IT_PROG_INTLTOOL" -e "AC_PROG_INTLTOOL" configure.*; then ...

For good measure, we can throw in a QA check that outputs a QA warning if the hit was on AC_PROG_INTLTOOL.
Comment 3 Gilles Dartiguelongue (RETIRED) gentoo-dev 2010-09-08 20:57:15 UTC
eclass has just been fixed in overlay with qawarn for the old macro. Thanks for reporting.