Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 321993

Summary: Please review Prefix changes for dev-vcs/mercurial-1.5.3
Product: Gentoo Linux Reporter: Fabian Groffen <grobian>
Component: New packagesAssignee: Dirkjan Ochtman (RETIRED) <djc>
Status: RESOLVED FIXED    
Severity: normal CC: djc, prefix
Priority: High    
Version: unspecified   
Hardware: All   
OS: All   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 315803    

Description Fabian Groffen gentoo-dev 2010-05-29 12:41:40 UTC
Please review and comment on the following changes to mercurial-1.5.3.ebuild. If you prefer, these can be committed as -r1.

--- mercurial-1.5.3.ebuild
+++ mercurial-1.5.3.ebuild
@@ -2,7 +2,7 @@
 # Distributed under the terms of the GNU General Public License v2
 # $Header: /var/cvsroot/gentoo-x86/dev-vcs/mercurial/mercurial-1.5.3.ebuild,v 1.1 2010/05/14 11:09:28 djc Exp $
 
-EAPI=2
+EAPI="3"
 
 inherit bash-completion elisp-common flag-o-matic eutils distutils
 
@@ -54,7 +54,7 @@
 
        rm -f doc/*.?.txt
        dodoc CONTRIBUTORS PKG-INFO README doc/*.txt
-       cp hgweb*.cgi "${D}"/usr/share/doc/${PF}/
+       cp hgweb*.cgi "${ED}"/usr/share/doc/${PF}/
 
        dobin hgeditor
        dobin contrib/hgk
@@ -63,11 +63,11 @@
        rm -f contrib/hgk contrib/hg-ssh
 
        rm -f contrib/bash_completion
-       cp -r contrib "${D}"/usr/share/doc/${PF}/
+       cp -r contrib "${ED}"/usr/share/doc/${PF}/
        doman doc/*.?
 
        cat > "${T}/80mercurial" <<-EOF
-HG=/usr/bin/hg
+HG="${EPREFIX}/usr/bin/hg"
 EOF
        doenvd "${T}/80mercurial"
Comment 1 Dirkjan Ochtman (RETIRED) gentoo-dev 2010-05-30 09:29:29 UTC
I think we prefer the API value to be without quotes? Looks fine otherwise.
Comment 2 Fabian Groffen gentoo-dev 2010-05-30 09:31:23 UTC
it is a string, but I'll use the notation you prefer.
Comment 3 Fabian Groffen gentoo-dev 2010-05-30 20:12:04 UTC
done, thanks